From: Coywolf Qi Hunt <coywolf@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: bunk@stusta.de, Andrew Morton <akpm@osdl.org>
Subject: Re: include-linux-blkdevh-extern-inline-static-inline.patch added to -mm tree
Date: Fri, 29 Jul 2005 11:07:27 +0800 [thread overview]
Message-ID: <2cd57c9005072820073091864@mail.gmail.com> (raw)
In-Reply-To: <200507290229.j6T2T6MP003818@shell0.pdx.osdl.net>
On 7/29/05, akpm@osdl.org <akpm@osdl.org> wrote:
>
> The patch titled
>
> include/linux/blkdev.h: "extern inline" -> "static inline"
>
> has been added to the -mm tree. Its filename is
>
> include-linux-blkdevh-extern-inline-static-inline.patch
>
...
>
>
> From: Adrian Bunk <bunk@stusta.de>
>
> "extern inline" doesn't make much sense.
"extern inline" does make sense, and it does make sense here. please
backout this patch. Hint: the address of block_size() is referenced.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> include/linux/blkdev.h | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN include/linux/blkdev.h~include-linux-blkdevh-extern-inline-static-inline include/linux/blkdev.h
> --- devel/include/linux/blkdev.h~include-linux-blkdevh-extern-inline-static-inline 2005-07-28 19:28:05.000000000 -0700
> +++ devel-akpm/include/linux/blkdev.h 2005-07-28 19:28:05.000000000 -0700
> @@ -727,7 +727,7 @@ static inline unsigned int blksize_bits(
> return bits;
> }
>
> -extern inline unsigned int block_size(struct block_device *bdev)
> +static inline unsigned int block_size(struct block_device *bdev)
> {
> return bdev->bd_block_size;
> }
--
Coywolf Qi Hunt
http://ahbl.org/~coywolf/
next parent reply other threads:[~2005-07-29 3:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200507290229.j6T2T6MP003818@shell0.pdx.osdl.net>
2005-07-29 3:07 ` Coywolf Qi Hunt [this message]
2005-07-29 4:42 ` include-linux-blkdevh-extern-inline-static-inline.patch added to -mm tree Coywolf Qi Hunt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd57c9005072820073091864@mail.gmail.com \
--to=coywolf@gmail.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=coywolf@lovecn.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox