* Re: include-linux-blkdevh-extern-inline-static-inline.patch added to -mm tree
[not found] <200507290229.j6T2T6MP003818@shell0.pdx.osdl.net>
@ 2005-07-29 3:07 ` Coywolf Qi Hunt
2005-07-29 4:42 ` Coywolf Qi Hunt
0 siblings, 1 reply; 2+ messages in thread
From: Coywolf Qi Hunt @ 2005-07-29 3:07 UTC (permalink / raw)
To: linux-kernel; +Cc: bunk, Andrew Morton
On 7/29/05, akpm@osdl.org <akpm@osdl.org> wrote:
>
> The patch titled
>
> include/linux/blkdev.h: "extern inline" -> "static inline"
>
> has been added to the -mm tree. Its filename is
>
> include-linux-blkdevh-extern-inline-static-inline.patch
>
...
>
>
> From: Adrian Bunk <bunk@stusta.de>
>
> "extern inline" doesn't make much sense.
"extern inline" does make sense, and it does make sense here. please
backout this patch. Hint: the address of block_size() is referenced.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> Signed-off-by: Andrew Morton <akpm@osdl.org>
> ---
>
> include/linux/blkdev.h | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN include/linux/blkdev.h~include-linux-blkdevh-extern-inline-static-inline include/linux/blkdev.h
> --- devel/include/linux/blkdev.h~include-linux-blkdevh-extern-inline-static-inline 2005-07-28 19:28:05.000000000 -0700
> +++ devel-akpm/include/linux/blkdev.h 2005-07-28 19:28:05.000000000 -0700
> @@ -727,7 +727,7 @@ static inline unsigned int blksize_bits(
> return bits;
> }
>
> -extern inline unsigned int block_size(struct block_device *bdev)
> +static inline unsigned int block_size(struct block_device *bdev)
> {
> return bdev->bd_block_size;
> }
--
Coywolf Qi Hunt
http://ahbl.org/~coywolf/
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: include-linux-blkdevh-extern-inline-static-inline.patch added to -mm tree
2005-07-29 3:07 ` include-linux-blkdevh-extern-inline-static-inline.patch added to -mm tree Coywolf Qi Hunt
@ 2005-07-29 4:42 ` Coywolf Qi Hunt
0 siblings, 0 replies; 2+ messages in thread
From: Coywolf Qi Hunt @ 2005-07-29 4:42 UTC (permalink / raw)
To: linux-kernel; +Cc: bunk, Andrew Morton
On 7/29/05, Coywolf Qi Hunt <coywolf@gmail.com> wrote:
> On 7/29/05, akpm@osdl.org <akpm@osdl.org> wrote:
> >
> > The patch titled
> >
> > include/linux/blkdev.h: "extern inline" -> "static inline"
> >
> > has been added to the -mm tree. Its filename is
> >
> > include-linux-blkdevh-extern-inline-static-inline.patch
> >
>
> ...
>
> >
> >
> > From: Adrian Bunk <bunk@stusta.de>
> >
> > "extern inline" doesn't make much sense.
>
> "extern inline" does make sense, and it does make sense here. please
> backout this patch. Hint: the address of block_size() is referenced.
>
Sorry, I mistook put_int(arg, block_size(bdev)); as address reference.
--
Coywolf Qi Hunt
http://ahbl.org/~coywolf/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-29 4:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200507290229.j6T2T6MP003818@shell0.pdx.osdl.net>
2005-07-29 3:07 ` include-linux-blkdevh-extern-inline-static-inline.patch added to -mm tree Coywolf Qi Hunt
2005-07-29 4:42 ` Coywolf Qi Hunt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox