From: Coywolf Qi Hunt <coywolf@gmail.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Jesper Juhl <jesper.juhl@gmail.com>,
Con Kolivas <kernel@kolivas.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] inline a few tiny functions in init/initramfs.c
Date: Wed, 28 Sep 2005 11:01:25 +0800 [thread overview]
Message-ID: <2cd57c90050927200118eb9ade@mail.gmail.com> (raw)
In-Reply-To: <1127872565.5210.4.camel@npiggin-nld.site>
On 9/28/05, Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> On Wed, 2005-09-28 at 02:07 +0200, Jesper Juhl wrote:
>
> > Ok, so it seems that there's agreement that the other two inlines in
> > the patch makes sense, but the malloc() is not clear cut.
> >
> > Since this is in initramfs after all it doesn't make that big a
> > difference overall, so I'll just send in a patch that inlines the
> > other two functions but leaves malloc() alone.
> >
>
> Well, they're not particularly performance critical, and everything
> is marked init anyway so I don't know why you would bother changing
> anything ;)
>
Don't you feel "static inline void __init " stupid? (inline + __init)
Anyway don't do things like that manually. Leave the optimization job
to gcc.
--
Coywolf Qi Hunt
http://sosdg.org/~coywolf/
next prev parent reply other threads:[~2005-09-28 3:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 23:26 [RFC][PATCH] inline a few tiny functions in init/initramfs.c Jesper Juhl
2005-09-24 4:15 ` Con Kolivas
2005-09-24 4:52 ` Nick Piggin
2005-09-28 0:07 ` Jesper Juhl
2005-09-28 1:56 ` Nick Piggin
2005-09-28 3:01 ` Coywolf Qi Hunt [this message]
2005-09-28 21:38 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2cd57c90050927200118eb9ade@mail.gmail.com \
--to=coywolf@gmail.com \
--cc=jesper.juhl@gmail.com \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox