From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx4+vqz1JQ/jipjjJs2nQSCk+W8xCnHqf7zAsUavt8d7f2DU4XwqXAYWVwSnNhb5NI2NO+bIY ARC-Seal: i=1; a=rsa-sha256; t=1523919978; cv=none; d=google.com; s=arc-20160816; b=lRUMn3qgu/d8maGU6b96/OcLLIusdO9c6lf2SYni8DPnCPLZbc8p/ldr1USqu5Lvwo rZhpYIVYggs+5ps4d6Not+FV5FfmxrXKEIc+RmpPB0ohjc7IOxX4O97BtO21e+VhoBSA FvTGc6ilZ+eEG3LSvDI3oyA51WeDeLWyzDIcGngx6WNTXKmwerNP7lqeQnbMu0jq+v0Z n3hHOxUDti3O1kpDs551XeQuvE4+1+89ALREE/JRygubYRfHFGPGjyETIehZNoD+xlPx PHgwBCAm9zP0a0tSEbc4/G/ryTWT/G/diQ42VW7ecXyQHCtbxuWV9ll1XSYyVgfeXsEl JQFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=bSZInII5+jtaGm9BEld7VahNdnyfoO94C7jgt8/C0Yw=; b=PoljMdpG1t1vfUvjKUrT4YTwISPaulN3/VyQ01YcaqmDVn4B/Pjg53ggECdF+u2Uua wVURSb2PpFAdRUV6cVhDNmvo2bPyPrFmczfUvNQ5IvKHI33Ib8fgoCw5SFdW3noDyLgw B1HTokvvPyPEqiF621aCy3vmJb5I5j1C3vn1Ew290oCwjXuK2xkzjEuREiZ/OPTBpO7U CrQltxdZU3QUcfExdsKsrP7TdZo+vZlpSxDlY6E5efzXiEGMXq+lBo+KZ0hfnt5JK5z6 OV1wn77MqZi8/q3Ft46roB/g3qzRZO+FcEBD/Zu/8MLoTWI+UO3vnbyydR6aSMp+TEWC xmfQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of jae.hyun.yoo@linux.intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=jae.hyun.yoo@linux.intel.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of jae.hyun.yoo@linux.intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=jae.hyun.yoo@linux.intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,461,1517904000"; d="scan'208";a="192001291" Subject: Re: [PATCH v3 01/10] Documentations: dt-bindings: Add documents of generic PECI bus, adapter and client drivers To: Rob Herring Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Greg KH , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os , Sumeet R Pawnikar , Vernon Mauery , linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-2-jae.hyun.yoo@linux.intel.com> <20180416175936.4vcse73mrnyk242m@rob-hp-laptop> From: Jae Hyun Yoo Message-ID: <2ce14097-e003-d59a-a05c-1cee55cb0929@linux.intel.com> Date: Mon, 16 Apr 2018 16:06:16 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180416175936.4vcse73mrnyk242m@rob-hp-laptop> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1597385124256903080?= X-GMAIL-MSGID: =?utf-8?q?1597945915243738020?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: Hi Rob, Thanks for sharing your time. Please see my answers inline. On 4/16/2018 10:59 AM, Rob Herring wrote: > On Tue, Apr 10, 2018 at 11:32:03AM -0700, Jae Hyun Yoo wrote: >> This commit adds documents of generic PECI bus, adapter and client drivers. > > "dt-bindings: ..." for the subject prefix please. > Sure, I'll change the subject. >> >> Signed-off-by: Jae Hyun Yoo >> Reviewed-by: Haiyue Wang >> Reviewed-by: James Feist >> Reviewed-by: Vernon Mauery >> Cc: Alan Cox >> Cc: Andrew Jeffery >> Cc: Andrew Lunn >> Cc: Andy Shevchenko >> Cc: Arnd Bergmann >> Cc: Benjamin Herrenschmidt >> Cc: Fengguang Wu >> Cc: Greg KH >> Cc: Guenter Roeck >> Cc: Jason M Biils >> Cc: Jean Delvare >> Cc: Joel Stanley >> Cc: Julia Cartwright >> Cc: Miguel Ojeda >> Cc: Milton Miller II >> Cc: Pavel Machek >> Cc: Randy Dunlap >> Cc: Stef van Os >> Cc: Sumeet R Pawnikar >> --- >> .../devicetree/bindings/peci/peci-adapter.txt | 23 ++++++++++++++++++++ >> .../devicetree/bindings/peci/peci-bus.txt | 15 +++++++++++++ >> .../devicetree/bindings/peci/peci-client.txt | 25 ++++++++++++++++++++++ > > This should be all one document. > Okay. I'll combine them into one document. >> 3 files changed, 63 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/peci/peci-adapter.txt >> create mode 100644 Documentation/devicetree/bindings/peci/peci-bus.txt >> create mode 100644 Documentation/devicetree/bindings/peci/peci-client.txt >> >> diff --git a/Documentation/devicetree/bindings/peci/peci-adapter.txt b/Documentation/devicetree/bindings/peci/peci-adapter.txt >> new file mode 100644 >> index 000000000000..9221374f6b11 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/peci/peci-adapter.txt >> @@ -0,0 +1,23 @@ >> +Generic device tree configuration for PECI adapters. >> + >> +Required properties: >> +- compatible : Should contain hardware specific definition strings that can >> + match an adapter driver implementation. >> +- reg : Should contain PECI controller registers location and length. > > No need for these 2 here. > Will drop these 2. >> +- #address-cells : Should be <1>. >> +- #size-cells : Should be <0>. > > Some details on the addressing for PECI would be good. > It is for the PECI client address. Will add details. >> + >> +Example: >> + peci: peci@10000000 { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x10000000 0x1000>; >> + > > This part of the example is not relevant. Just start with the adapter > node. > Will remove that part. Thanks! >> + peci0: peci-bus@0 { >> + compatible = "soc,soc-peci"; >> + reg = <0x0 0x1000>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + }; >> + }; >> diff --git a/Documentation/devicetree/bindings/peci/peci-bus.txt b/Documentation/devicetree/bindings/peci/peci-bus.txt >> new file mode 100644 >> index 000000000000..90bcc791ccb0 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/peci/peci-bus.txt >> @@ -0,0 +1,15 @@ >> +Generic device tree configuration for PECI buses. >> + >> +Required properties: >> +- compatible : Should be "simple-bus". > > I don't understand what this has to do with PECI? "simple-bus" already > has a defined meaning. > Maybe I'm wrong but I intended to show this node is an umbrella node of a PECI bus subsystem. What should I use then? >> +- #address-cells : Should be <1>. >> +- #size-cells : Should be <1>. >> +- ranges : Should contain PECI controller registers ranges. >> + >> +Example: >> + peci: peci@10000000 { >> + compatible = "simple-bus"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + ranges = <0x0 0x10000000 0x1000>; >> + }; >> diff --git a/Documentation/devicetree/bindings/peci/peci-client.txt b/Documentation/devicetree/bindings/peci/peci-client.txt >> new file mode 100644 >> index 000000000000..8e2bfd8532f6 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/peci/peci-client.txt >> @@ -0,0 +1,25 @@ >> +Generic device tree configuration for PECI clients. >> + >> +Required properties: >> +- compatible : Should contain target device specific definition strings that can >> + match a client driver implementation. > > Bindings are for h/w, not client drivers. > > How are PECI devices defined? > Got it. I'll correct the description. PECI client device is Intel CPU which is connected through a PECI bus. >> +- reg : Should contain address of a client CPU. Address range of CPU >> + clients is starting from 0x30 based on PECI specification. >> + <0x30> .. <0x37> (depends on the PECI_OFFSET_MAX definition) > > 8 devices should be enough for anyone... > > Where is PECI_OFFSET_MAX defined? > PECI_OFFSET_MAX is defined in include/linux/peci.h based on the maximum CPU numbers of the current IA generation. I'll remove the unnecessary details. A setting out of range would be handled accordingly in kernel. >> + >> +Example: >> + peci-bus@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + < more properties > >> + >> + function@cpu0 { > > Not a valid node name. "function@30" is what it probably should be. For > a new bus you can define unit-address format you like, but it must be > based on the contents of reg. However, it doesn't look like you should > create anything special here. > Got it. I'll fix these node name like function@30 and function@31. Thanks a lot for your comments! -Jae >> + compatible = "device,function"; >> + reg = <0x30>; >> + }; >> + >> + function@cpu1 { >> + compatible = "device,function"; >> + reg = <0x31>; >> + }; >> + }; >> -- >> 2.16.2 >> >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel