From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751897AbdFSRV6 (ORCPT ); Mon, 19 Jun 2017 13:21:58 -0400 Received: from mail-qk0-f196.google.com ([209.85.220.196]:36786 "EHLO mail-qk0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbdFSRV5 (ORCPT ); Mon, 19 Jun 2017 13:21:57 -0400 Subject: Re: [PATCH] mips: bcm63xx: spi: Fix checkpatch.pl warnings To: Aravind Thokala , Mark Brown Cc: bcm-kernel-feedback-list@broadcom.com, linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1497890980-4334-1-git-send-email-aravind.thk@gmail.com> From: Florian Fainelli Message-ID: <2d01bbe8-33bd-9aea-8906-0fe54bb2c334@gmail.com> Date: Mon, 19 Jun 2017 10:21:51 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1497890980-4334-1-git-send-email-aravind.thk@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/19/2017 09:49 AM, Aravind Thokala wrote: > This patch fixes the checkpatch.pl warnings on the driver > file. > > Signed-off-by: Aravind Thokala The subject should be spi/bcm63xx: Fix checkpatch warnings to be consistent with previous submissions done to that file. With that: Reviewed-by: Florian Fainelli > --- > drivers/spi/spi-bcm63xx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c > index 247f71b..84c7356 100644 > --- a/drivers/spi/spi-bcm63xx.c > +++ b/drivers/spi/spi-bcm63xx.c > @@ -147,7 +147,7 @@ struct bcm63xx_spi { > > /* Platform data */ > const unsigned long *reg_offsets; > - unsigned fifo_size; > + unsigned int fifo_size; > unsigned int msg_type_shift; > unsigned int msg_ctl_width; > > @@ -191,7 +191,7 @@ static inline void bcm_spi_writew(struct bcm63xx_spi *bs, > #endif > } > > -static const unsigned bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = { > +static const unsigned int bcm63xx_spi_freq_table[SPI_CLK_MASK][2] = { > { 20000000, SPI_CLK_20MHZ }, > { 12500000, SPI_CLK_12_50MHZ }, > { 6250000, SPI_CLK_6_250MHZ }, > -- Florian