From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Shibo Li <zzutcyha@163.com>,
Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8712: Fix multiple line dereference
Date: Mon, 20 Feb 2023 20:13:23 +0100 [thread overview]
Message-ID: <2d045c1a-5947-1ce4-b5cd-a1684761a812@gmail.com> (raw)
In-Reply-To: <20230220084050.18459-1-zzutcyha@163.com>
On 2/20/23 09:40, Shibo Li wrote:
> This patch fixes the following warning in rtl871x_mlme.c
>
> WARNING: Avoid multiple line dereference - prefer 'adapter->securitypriv.PrivacyAlgrthm'
>
> Signed-off-by: Shibo Li <zzutcyha@163.com>
> ---
> drivers/staging/rtl8712/rtl871x_mlme.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index 63e12b157001..cc47c1cedd4e 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -773,8 +773,8 @@ void r8712_joinbss_event_callback(struct _adapter *adapter, u8 *pbuf)
> adapter->securitypriv.busetkipkey = false;
> adapter->securitypriv.bgrpkey_handshake = false;
> ptarget_sta->ieee8021x_blocked = true;
> - ptarget_sta->XPrivacy = adapter->
> - securitypriv.PrivacyAlgrthm;
> + ptarget_sta->XPrivacy =
> + adapter->securitypriv.PrivacyAlgrthm;
> memset((u8 *)&ptarget_sta->x_UncstKey,
> 0,
> sizeof(union Keytype));
Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> AW-NU120
next prev parent reply other threads:[~2023-02-20 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 8:40 [PATCH] staging: rtl8712: Fix multiple line dereference Shibo Li
2023-02-20 15:00 ` Dan Carpenter
2023-02-20 19:13 ` Philipp Hortmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-04-04 21:00 Alaa Mohamed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d045c1a-5947-1ce4-b5cd-a1684761a812@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=florian.c.schilhabel@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=zzutcyha@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox