From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5072C4167B for ; Thu, 30 Nov 2023 12:47:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345386AbjK3MrT (ORCPT ); Thu, 30 Nov 2023 07:47:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54096 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231970AbjK3MrR (ORCPT ); Thu, 30 Nov 2023 07:47:17 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0961D50 for ; Thu, 30 Nov 2023 04:47:23 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 523C8C433C8; Thu, 30 Nov 2023 12:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701348443; bh=ltZg2E6aTzAR6MTRF7EIVGqc75LpYNO0JU7AzaW5iyE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dabbuH3m0BMxxTaY01Bvmd8CjoKVWDsdJ3trvLLtZHMvWxtO98UkSGBXSaRG41gJr m/BQjiCuLYcL1m2FkM6QXjAOwrGUoYKN9NC36nO4WRBNrGUkZlSs12In95Lkx+xvoR dAjsNh2zPrxJeoQM/do0EwSMrtTvQLyUKT41KeUkFA3PPaVLnPQY7q7fbW3uCSQVln HgubtUFlcaheOCk9cI1Rm1VgNdi4pYYc4A9OWevdZw0N1HNpsL5QTtpNE6Baa9WrgN dS+TwakXM2RGDuD4HQ4exJ3lEKkfygHH/9o5/TotjzYfn0E8ynR9jTjx8V+FuXh0n7 cH9vn1bphEkIw== MIME-Version: 1.0 Date: Thu, 30 Nov 2023 13:47:17 +0100 From: Michael Walle To: Chun-Kuang Hu , Philipp Zabel , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Matthias Brugger , AngeloGioacchino Del Regno , Jitao Shi , Xinlei Lee Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org Subject: Re: [PATCH 4/4] drm/mediatek: support the DSI0 output on the MT8195 VDOSYS0 In-Reply-To: <20231123133749.2030661-5-mwalle@kernel.org> References: <20231123133749.2030661-1-mwalle@kernel.org> <20231123133749.2030661-5-mwalle@kernel.org> Message-ID: <2d1bae2239626cb51977bf0803cec602@kernel.org> X-Sender: mwalle@kernel.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > With the latest dynamic selection of the output component, we can now > support different outputs. Move current output component into the > dynamic routes array and add the new DSI0 output. > > Signed-off-by: Michael Walle > --- > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > index 2b0c35cacbc6..6fa88976376e 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > @@ -222,7 +222,11 @@ static const unsigned int mt8195_mtk_ddp_main[] = > { > DDP_COMPONENT_DITHER0, > DDP_COMPONENT_DSC0, > DDP_COMPONENT_MERGE0, > - DDP_COMPONENT_DP_INTF0, Please disregard this patch (the others are ok). There must gone something wrong during my testing. DDP_COMPONENT_MERGE0 won't work with DDP_COMPONENT_DSI0. If anyone has more insights, I'm all ears. -michael > +}; > + > +static const struct mtk_drm_route mt8195_mtk_ddp_main_routes[] = { > + { 0, DDP_COMPONENT_DP_INTF0 }, > + { 0, DDP_COMPONENT_DSI0 }, > }; > > static const unsigned int mt8195_mtk_ddp_ext[] = { > @@ -308,6 +312,8 @@ static const struct mtk_mmsys_driver_data > mt8192_mmsys_driver_data = { > static const struct mtk_mmsys_driver_data mt8195_vdosys0_driver_data = > { > .main_path = mt8195_mtk_ddp_main, > .main_len = ARRAY_SIZE(mt8195_mtk_ddp_main), > + .conn_routes = mt8195_mtk_ddp_main_routes, > + .num_conn_routes = ARRAY_SIZE(mt8195_mtk_ddp_main_routes), > .mmsys_dev_num = 2, > };