public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Nam Cao <namcao@linutronix.de>,
	gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] staging: rtl8192e: remove dead code
Date: Mon, 27 May 2024 10:34:41 +0200	[thread overview]
Message-ID: <2d1dab52-72ab-4f4d-8f77-ae54f16b9b4a@gmail.com> (raw)
In-Reply-To: <9802cc9e-5962-44a1-a384-3e5ee226cbcb@moroto.mountain>

Am 27.05.24 um 09:39 schrieb Dan Carpenter:
> This patch doesn't affect behavior at all, but to me the original
> author wrote the do nothing case for readability, and I don't have a
> problem with that.  In fact, I applaud the author for caring about
> readability at all which is not a given in staging code.  :P

Then I think it's better to leave it as is. :)
Should I send a v2 with this patched removed or will Greg just apply
the first two patches and ignore this one?

thanks,
Michael


  reply	other threads:[~2024-05-27  8:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-26 11:19 [PATCH 0/3] staging: rtl8192e: some refactoring Michael Straube
2024-05-26 11:19 ` [PATCH 1/3] staging: rtl8192e: reduce indentation level Michael Straube
2024-05-26 14:23   ` Nam Cao
2024-05-26 11:19 ` [PATCH 2/3] staging: rtl8192e: remove unnecessary line breaks Michael Straube
2024-05-26 14:33   ` Nam Cao
2024-05-26 11:19 ` [PATCH 3/3] staging: rtl8192e: remove dead code Michael Straube
2024-05-26 14:31   ` Nam Cao
2024-05-27  4:36     ` Michael Straube
2024-05-27  7:39       ` Dan Carpenter
2024-05-27  8:34         ` Michael Straube [this message]
2024-05-27  8:51           ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2d1dab52-72ab-4f4d-8f77-ae54f16b9b4a@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=namcao@linutronix.de \
    --cc=philipp.g.hortmann@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox