Re: [PATCH 08/13] dt-bindings: soc/microchip: add bindings for mpfs system services

Krzysztof Kozlowski
2021-11-08T21:20:58Z

On 08/11/2021 16:05, conor.dooley@microchip.com wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
>
> Add device tree bindings for the services provided by the system
> controller directly on the Microchip PolarFire SoC.
>
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
> ---
> .../microchip,mpfs-generic-service.yaml | 31 +++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-generic-service.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-generic-service.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-generic-service.yaml
> new file mode 100644
> index 000000000000..f89d3a74c059
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs-generic-service.yaml
> @@ -0,0 +1,31 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/soc/microchip/microchip,mpfs-generic-service.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Microchip MPFS system services
> +
> +maintainers:
> + - Conor Dooley <conor.dooley@microchip.com>
> +
> +properties:
> + compatible:
> + const: microchip,mpfs-generic-service
> +
> + syscontroller:
> + maxItems: 1
> + description: name of the system controller device node

Same comment as for rng patch.

> +
> +required:
> + - compatible
> + - "syscontroller"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + sysserv: sysserv {
> + compatible = "microchip,mpfs-generic-service";
> + syscontroller = <&syscontroller>;
> + };
>

Best regards,
Krzysztof