From: Alexander Lobakin <aleksander.lobakin@intel.com>
To: Petr Oros <poros@redhat.com>
Cc: <netdev@vger.kernel.org>, <jesse.brandeburg@intel.com>,
<anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<scott.w.taylor@intel.com>, <intel-wired-lan@lists.osuosl.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v3] ice: copy last block omitted in ice_get_module_eeprom()
Date: Fri, 3 Mar 2023 12:12:40 +0100 [thread overview]
Message-ID: <2d221713-cafa-8460-df6b-ccd11f42e4cb@intel.com> (raw)
In-Reply-To: <20230301204707.2592337-1-poros@redhat.com>
From: Petr Oros <poros@redhat.com>
Date: Wed, 1 Mar 2023 21:47:07 +0100
> ice_get_module_eeprom() is broken since commit e9c9692c8a81 ("ice:
> Reimplement module reads used by ethtool") In this refactor,
> ice_get_module_eeprom() reads the eeprom in blocks of size 8.
> But the condition that should protect the buffer overflow
> ignores the last block. The last block always contains zeros.
[...]
> Fixes: e9c9692c8a81 ("ice: Reimplement module reads used by ethtool")
> Signed-off-by: Petr Oros <poros@redhat.com>
Reviewed-by: Alexander Lobakin <aleksander.lobakin@intel.com>
> ---
> v2: memcpy unified calls
> v3: copy_len is now declared in if scope
> unwrapped line before memcpy
[...]
Thanks,
Olek
prev parent reply other threads:[~2023-03-03 11:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 20:47 [PATCH net v3] ice: copy last block omitted in ice_get_module_eeprom() Petr Oros
2023-03-01 22:27 ` Jesse Brandeburg
2023-03-03 11:12 ` Alexander Lobakin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d221713-cafa-8460-df6b-ccd11f42e4cb@intel.com \
--to=aleksander.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=scott.w.taylor@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox