From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 89B5733E350 for ; Tue, 3 Feb 2026 12:23:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121439; cv=none; b=CFuVAdFvf6fgGeHoE5HYuJAuxxLLiCy30fb1D9mHmWJBFot3hU79+1kx0HkvgzZyVs1T9G6E0eLTRa9NAxgx8yA0XWqctr6UYRTC1tBzwJPqbZDU1A84yp7sLhb+j3A9wPSzVIkKmhfQTqhBYq0OU6Y3k4cnaP0l1Ubz3W17NrA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770121439; c=relaxed/simple; bh=1beno9bJ66kwAx9wlruDfw1G3tmXkab6b6hnYrIXZ0U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=djdSzzXhtotYm6lJRQbCvDGNaHmQRvFdRHx4PYZqMBufkax6KnQ9LFvcICXdQ1Ssu3/kQmR53k1qO9+4V5qI+1GXXxJnWlBqU5mnKi93xbqVH0kBnoh6EXOMHd0c4utMlOPoJ2i5bXzetAi7ayfDH6rRz2/ZvU0gDXjQc1sJCZY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=EEXxhyiR; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CMZ3oVZf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="EEXxhyiR"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CMZ3oVZf" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 613BLq932847348 for ; Tue, 3 Feb 2026 12:23:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oYO3cR/k1KFc/9QYbB0PIjXcwT9hHSS+VNzE2GCCgfc=; b=EEXxhyiRJfZFSbZB ajzLxTCZss5ndJE2qW6VtPKK8g+B44amSCDEsbDTaikwDjlUsvnLQ6Zwq8fitPvO DZZPGjXUvxZpj4st/oQOfIp32RVOTXYrgJ/qb54ytx8ZPDfRC2ZqJdo2ta7n7TLn Jw5boOaealA3fgOPaNQdNbGTm9K2FkiOkwa9yCTGIXgHc5hbUCwQOSx5oVsGIK4B ckwnFuT4V/XElfYaHcT0z3TznEnciJQCsHn3PyOi4H0ds8oLx4IxmcCIF17wO4IL 5V+hIZiSlNaWOLVbzgst7lYFDXkUekyp37hoRxSGwZW7uWjqSxS1eUphEx2QEJzX A55x/g== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c3g33g5g5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 03 Feb 2026 12:23:56 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-88882c9b4d0so13729406d6.0 for ; Tue, 03 Feb 2026 04:23:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770121435; x=1770726235; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oYO3cR/k1KFc/9QYbB0PIjXcwT9hHSS+VNzE2GCCgfc=; b=CMZ3oVZfH5p4OTvp+N8orfIiyxcv30PJN7APWCIz+bbMRlsDVNvaT51MGPT4Ql5CFm k5K3mJUqxdVinvbNCkvcrn+90uI5YyP7AqySi3S+zkchHSYBKDA36QYEvWoO7hqW1mXP M3/hUrrP7KzkDTQCQmP2HB407yj1hablwwcVel7sVzpFU7GEfklnnSdo3y4MVYn1ARXi 4CZjcbna135j48xM9eGIMsXSPzySAEH8/Jy63OnpSf+zIdHqW96dHwywHTyPE/5MFxhE 0FsadUU5wYtbBSox38G3q9vYXZNvIGZ7CwEcOEledjAKzegwxID3+nEj6AfeiQa3Ovb9 ZAzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770121435; x=1770726235; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oYO3cR/k1KFc/9QYbB0PIjXcwT9hHSS+VNzE2GCCgfc=; b=bTRCaXGQk+T8DwjE45I3idc3vCpCeA1andaoKZpfmKt2ET/2WqZ03irXYeFMH5LBFx 9+G394+l9qVjz3zP4AvV8aIafuNHkWwRbajaDyOwO6g+levGiacJq3PphoiVk5CCX1/B eMEXopyCQyBk8MRNwu73cakkrZ9YB26lyIfSGU9AGwJBfKSvmuk5zWBDYf6UpDrgnEsV Lx6GxkuQcAfa801MeVn0LyNwmCVNIkib679QMXGeyvD22NAKaDT/n+zunuEPqKDpeoaF YrxUZ7H+Q0MXVKmVlYh6vF7XXkc+bwXxeqZxnj0nsYUmQsjXzaN12Iim8W5/FbiN07sR RWJg== X-Forwarded-Encrypted: i=1; AJvYcCVXFQrEBEHrsTUYNHEqTl6UEaD3RrCIl5db9FmoqVaqnUW62GULf6CDiZqvTsV4O+Gl9WlsAumi4mhiajE=@vger.kernel.org X-Gm-Message-State: AOJu0YzBJg7bFksBsYLSy6t1z0/HDj7fL3RrT1GUk2iaxVFxK8psZU0W LvzuveU8k9VQb4PpMeD/6f/lcPnl89B3dFAWSN5jhSQDAWCi8t+l9490ARHBk0ABkh5BzmqrfVk BwCqqq423nqKaDKDtBZbPqRrG4d4/i5davUpEOJjcJE9PsaOmi4HosIRIe+BbWaMKss8= X-Gm-Gg: AZuq6aIJMXkeh/o5Xs27aNszr8IPgwEZkeOEpFLy+VLrx/Mg8MA/vYORPnE9cE+aOEc 80W2yUEq+sJo/nuQiym6dqZtHYr1saQNHUsSFZWcVMQ+EMQdTt4HTMsBlyWWb0yf/+JKfdNUOdg u77lWkCbrNNo0ediTnCy7D5BWpcut3/OylkxVbOok+6y96OEk/yQvUOVTSZDH0EzxAFycTwOrSm EpSDdn2HUQGHzdOK1yDnrgtpxyZSFXHxAH1HQL2WUmIa473qvMFuHtztlvJiFEdfP9skIwssKgk EJxngB938O9RK09RaVThwDZNiQsFiJI1jCj1QTmPW0h/dmvE4Uv4SN07Ao7Tlc6Tk0hV+N4dHrf iJAAB7LKqxzSTC/r9S6OKi4/v5fctrWd7zw6vEV20BwEnwNUG80n1cWa6RDmIRLKVFvE= X-Received: by 2002:a05:6214:4d03:b0:894:6c97:691b with SMTP id 6a1803df08f44-894ea075718mr154409126d6.6.1770121435511; Tue, 03 Feb 2026 04:23:55 -0800 (PST) X-Received: by 2002:a05:6214:4d03:b0:894:6c97:691b with SMTP id 6a1803df08f44-894ea075718mr154408786d6.6.1770121435029; Tue, 03 Feb 2026 04:23:55 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-658b4691e53sm9060151a12.21.2026.02.03.04.23.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Feb 2026 04:23:53 -0800 (PST) Message-ID: <2d2bc77b-715d-4484-86c4-4389ebb63856@oss.qualcomm.com> Date: Tue, 3 Feb 2026 13:23:50 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 06/13] soc: qcom: geni-se: Introduce helper API for attaching power domains To: Praveen Talari , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Mukesh Kumar Savaliya , Viken Dadhaniya , Bjorn Andersson , Konrad Dybcio , linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com Cc: prasad.sodagudi@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com References: <20260202180922.1692428-1-praveen.talari@oss.qualcomm.com> <20260202180922.1692428-7-praveen.talari@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260202180922.1692428-7-praveen.talari@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=afVsXBot c=1 sm=1 tr=0 ts=6981e8dc cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=9pTQncvtRyGiLAFmc8cA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-ORIG-GUID: CvDRELXZLru04ThKyGvdx1yEpbeguudt X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjAzMDA5OCBTYWx0ZWRfX7zp99C3Y+tEU 1Ue4wiIUZSFYTFEKG1PH7W0Jf0zX1HD7b9MN7Jzqd0RFkp7hQurR3H7cJeSVSD2QHxCt0Ovq6l4 ogxqbrJEm6dX3Det37UMtk83QPPmQBYXs0yPZqIsl7grz10JerWJ7kn1tYM0aOHDCKpUzDwgalB 1EWohgcbAn54EEzYhs/39SDEf5mYM5hgCZghWdEGZFsWg5gzno+cA0bOLOHC/e1JQxK6ydtvmq6 u/4VjZq1tLMijav7QrGFu3m3QyXq3HqJDX7FjmHNv2SWD7cU3acoNQhL28HuyHg8HKXOVKVuJCv zRmdUWWoFYVPD7sPj3O8D4XmnZz3fChp2YDQQ54UAuYdRUXfypKIu72mcr3B42azIdCXOE3hjmx mbKoy8soVDCu2T/W35L6MoSeLY21lCO9Vtd2vFj80rFg00KcTsVuF1cov/KjynMyknKVVDHKn++ pw2P6cs1Zyir7r+Us1w== X-Proofpoint-GUID: CvDRELXZLru04ThKyGvdx1yEpbeguudt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-03_04,2026-02-02_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602030098 On 2/2/26 7:09 PM, Praveen Talari wrote: > The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently handle > the attachment of power domains. This often leads to duplicated code > logic across different driver probe functions. > > Introduce a new helper API, geni_se_domain_attach(), to centralize > the logic for attaching "power" and "perf" domains to the GENI SE > device. > > Signed-off-by: Praveen Talari > --- [...] > +int geni_se_domain_attach(struct geni_se *se) > +{ > + struct dev_pm_domain_attach_data pd_data = { > + .pd_flags = PD_FLAG_DEV_LINK_ON, > + .pd_names = (const char*[]) { "power", "perf" }, > + .num_pd_names = 2, > + }; > + int ret; > + > + ret = dev_pm_domain_attach_list(se->dev, > + &pd_data, &se->pd_list); Let's use devm_pm_domain_attach_list() (notice the 'm'), as the list is never detached from at the moment otherwise lgtm Konrad