Re: [PATCH v3 RESEND] PCI: Introduce Cray ClusterStor E1000 NVMe slot LED driver

Pavel Machek
2025-05-19T10:58:28Z

[-- Attachment #1: Type: text/plain, Size: 1549 bytes --]

Hi!

> Add driver to control the NVMe slot LEDs on the Cray ClusterStor E1000.
> The driver provides hotplug attention status callbacks for the 24 NVMe
> slots on the E1000. This allows users to access the E1000's locate and
> fault LEDs via the normal /sys/bus/pci/slots/<slot>/attention sysfs
> entries. This driver uses IPMI to communicate with the E1000 controller
> to toggle the LEDs.
>
> Signed-off-by: Tony Hutter <hutter2@llnl.gov>

We have LED subsystem.

> +++ b/Documentation/ABI/testing/sysfs-bus-pci
> @@ -231,6 +231,27 @@ Description:
> - scXX contains the device subclass;
> - iXX contains the device class programming interface.
>
> +What: /sys/bus/pci/slots/.../attention
> +Date: February 2025
> +Contact: linux-pci@vger.kernel.org
> +Description:
> + The attention attribute is used to read or write the attention
> + status for an enclosure slot. This is often used to set the
> + slot LED value on a NVMe storage enclosure.
> +
> + Common values:
> + 0 = OFF
> + 1 = ON
> + 2 = blink (ampere, ibmphp, pciehp, rpaphp, shpchp)
> +
> + Using the pciehp_craye1k extensions:
> + 0 = fault LED OFF, locate LED OFF
> + 1 = fault LED ON, locate LED OFF
> + 2 = fault LED OFF, locate LED ON
> + 3 = fault LED ON, locate LED ON
> +
> + Other values are no-op, OFF, or ON depending on the driver.
> +

And this should use it.

Best regards,
Pavel
--
I don't work for Nazis and criminals, and neither should you.
Boycott Putin, Trump, and Musk!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]