From: Sinan Kaya <okaya@codeaurora.org>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: Netdev <netdev@vger.kernel.org>,
Timur Tabi <timur@codeaurora.org>,
sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
intel-wired-lan <intel-wired-lan@lists.osuosl.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [Intel-wired-lan] [PATCH v3 09/18] fm10k: Eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 16 Mar 2018 12:33:14 -0400 [thread overview]
Message-ID: <2d346b70-70d4-5996-24ce-94031ee68c90@codeaurora.org> (raw)
In-Reply-To: <CAKgT0UcKdCpzFgX4qn7EdYnedOsJa9as5g24tfb6qFLXTxZ29A@mail.gmail.com>
On 3/16/2018 12:30 PM, Alexander Duyck wrote:
> On Fri, Mar 16, 2018 at 9:16 AM, Sinan Kaya <okaya@codeaurora.org> wrote:
>> Code includes wmb() followed by writel(). writel() already has a
>> barrier on some architectures like arm64.
>>
>> This ends up CPU observing two barriers back to back before executing
>> the register write.
>>
>> Since code already has an explicit barrier call, changing writel() to
>> writel_relaxed().
>>
>> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
>
> You can update the writel call in fm10k_tx_map as well.
>
> Of the drivers updated in drivers/net/ethernet/intel/* it looks like
> this is the only one that still requires any additional changes.
will do. thanks for the feedback.
>
> Thanks.
>
> - Alex
>
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-03-16 16:33 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1521216991-28706-1-git-send-email-okaya@codeaurora.org>
2018-03-16 16:16 ` [PATCH v3 01/18] i40e/i40evf: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 02/18] ixgbe: eliminate " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 03/18] igbvf: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 04/18] igb: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 05/18] ixgbevf: keep writel() closer to wmb() Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 06/18] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 07/18] drivers: net: cxgb: Eliminate " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 08/18] scsi: hpsa: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 09/18] fm10k: " Sinan Kaya
2018-03-16 16:30 ` [Intel-wired-lan] " Alexander Duyck
2018-03-16 16:33 ` Sinan Kaya [this message]
2018-03-16 16:16 ` [PATCH v3 10/18] net: qla3xxx: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 11/18] qlcnic: " Sinan Kaya
2018-03-19 20:10 ` Chopra, Manish
2018-03-16 16:16 ` [PATCH v3 12/18] bnx2x: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 13/18] net: cxgb4/cxgb4vf: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 14/18] net: cxgb3: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 15/18] RDMA/bnxt_re: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 16/18] IB/mlx4: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 17/18] RDMA/i40iw: " Sinan Kaya
2018-03-16 16:16 ` [PATCH v3 18/18] infiniband: cxgb4: " Sinan Kaya
2018-03-16 21:05 ` Steve Wise
2018-03-16 21:46 ` Sinan Kaya
2018-03-16 23:05 ` Steve Wise
2018-03-17 3:40 ` Sinan Kaya
2018-03-17 4:03 ` Sinan Kaya
2018-03-17 4:25 ` Sinan Kaya
2018-03-17 4:30 ` Timur Tabi
2018-03-17 13:23 ` Steve Wise
2018-03-17 13:27 ` David Miller
2018-03-17 15:05 ` Jason Gunthorpe
2018-03-17 18:30 ` Sinan Kaya
2018-03-19 1:48 ` Jason Gunthorpe
2018-03-16 22:13 ` Jason Gunthorpe
2018-03-16 23:04 ` Steve Wise
2018-03-17 4:08 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d346b70-70d4-5996-24ce-94031ee68c90@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=alexander.duyck@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox