Re: [PATCH 10/10] ASoC: Intel: soc-acpi: Add CS35L56 Soundwire to TGL

Pierre-Louis Bossart
2023-02-21T16:59:23Z

> +static const struct snd_soc_acpi_link_adr up_extreme_cs35l56_sdw0_one[] = {
> + {
> + .mask = BIT(0),
> + .num_adr = 1,
> + .adr_d = cs35l56_sdw0_adr,
> + },
> + {}
> +};
> +
> +static const struct snd_soc_acpi_link_adr up_extreme_cs35l56_sdw0_four[] = {
> + {
> + .mask = BIT(0),
> + .num_adr = 4,
> + .adr_d = cs35l56_sdw0_adr,
> + },
> + {}
> +};

If the machine driver has support for the 2-amplifier configuration,
shouldn't it be present here as well?

> +
> /* this table is used when there is no I2S codec present */
> struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[] = {
> /* mockup tests need to be first */
> @@ -501,6 +546,18 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[] = {
> .drv_name = "sof_sdw",
> .sof_tplg_filename = "sof-tgl-rt711.tplg",
> },
> + {
> + .link_mask = BIT(0),
> + .links = up_extreme_cs35l56_sdw0_four,
> + .drv_name = "sof_sdw",
> + .sof_tplg_filename = "sof-tgl-cs35l56-sdw0.tplg"
> + },
> + {
> + .link_mask = BIT(0),
> + .links = up_extreme_cs35l56_sdw0_one,
> + .drv_name = "sof_sdw",
> + .sof_tplg_filename = "sof-tgl-cs35l56-sdw0.tplg"
> + },
> {},
> };
> EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_tgl_sdw_machines);