Re: [PATCH v3 04/25] dt-bindings: sound: qcom: Add bindings for q6afe

Mark Brown
2018-03-01T20:41:47Z

[-- Attachment #1: Type: text/plain, Size: 714 bytes --]

On Tue, Feb 13, 2018 at 04:58:16PM +0000, srinivas.kandagatla@linaro.org wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Please submit patches using subject lines reflecting the style for the
subsystem. This makes it easier for people to identify relevant
patches. Look at what existing commits in the area you're changing are
doing and make sure your subject lines visually resemble what they're
doing.

> +- but must contain the following property:
> +
> +- compatible:
> +- qcom,apr-svc-id
> +- qcom,apr-svc-name
> +- #sound-dai-cells

Property or properties? It's a bit surprising that both the ID and the
name are mandatory, does the name actually get used for non-diagnostic
reasons?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]