From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D074B2C08AC for ; Thu, 15 Jan 2026 17:18:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768497518; cv=none; b=HBJ0ZK0kRHRjxRzmFXEjcjo8IsYeyOQ64kShSfFSAGgOZ+07i1d95/B2eXPsaYbVwzq6RCxHS+VNIWO4liOTNtUlmi9DWXjLXoTUqGMVUwevxmgSDi/rnnsUy3Q2C9kAx629YI5brJ/+dyD2bwS+wYxzYJvAn02XSLjmJAhpItU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768497518; c=relaxed/simple; bh=K/vy1qEg3m2FBJtsqOcztF+AuuEyEkHNUiTCD/3I0V8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YZT1dj99ZMlF2yXoq6+T9uyA1QkAeV7YHB4KE+qBaX8+t7WpKAU6rsQ2mDc3bLHGg779begLjI+dLfFWdhWKfAAtQnenIAT0J1u3R7uQDSlNoa3rwmO4YBQONQxGFVL9PqwsuVKVJxmsvY5n3yRd00xlYiYwjHZ80xkQhCIQR9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=p0Z5r5cn; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="p0Z5r5cn" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-7cfd6f321b5so559534a34.2 for ; Thu, 15 Jan 2026 09:18:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1768497515; x=1769102315; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=GN+hqp+80QaIO1nDdbtDssuKYlwNsYnFj1H6BNxd/io=; b=p0Z5r5cnzWQ52ddBMfGcWz+yXXM7QTfx7bpsAJ7DZ2Gvwqzmzfr5slvG9FMp+3ogIj WbnMhYlMvHsuCSWEuxaXnXEjibm5JPWnwnt75+luPdp76WJp7/ourDugzNMI/X50YoHc 2bxtgzJ1mo8YK4pDWyp1tIePUEiBYfoYXZy9oNUyvq/xemqmwV7TI3a0bOCPg/E9673P dGloQLhOQDLoWA1qqpOa/Nevfiif8OEBvZIkMrXCcALn+7Yz/rS7Y8oSZCl9kXeEFOcw kyKNf3HNH9ATVUCHHfuuHJpQy8TRXd5mgfLJiRL8mRoJyDoMu1nOMito7Q0J9vVFa0RB jFXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768497515; x=1769102315; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GN+hqp+80QaIO1nDdbtDssuKYlwNsYnFj1H6BNxd/io=; b=GqAPM3TDWQD4GIzXjcaCulDkLy8GbUV2k//BBu2i6IQCUggSsf7nONjaAbQS3jQYDW 56EEJqvZDsLRF5kDsDOopokjdrT/woGWBNNWjO7cXip7TPmNTdIj70wcNbfhAMmALEdf HFxm2r7Phl+oMYaAl3LObnGUEGnWKhgkXyxbe1PUoQepwr4Mse3ReYpa2PVuuLxpHekc daazezFAMo2f0+CKJa7+z+OAshEyQUp+jcazjFZ6u+LOGMlDrqzL3HIR2znDkOBcVndA jtO63JFggi1v9lMn7LIeYnpMlQ5sSDOEVNug1ZnJngbmY+faZ6gmbMdT+l5+NGi/Pi0W RjTg== X-Gm-Message-State: AOJu0YwIEMn9Pg6TCWX5r3uWCUdOOpYFjEOWC9KItQkJAXXvjY7aWrKW J9VYZUhJooD8V3kXsAFwjU9U1dNhzjqE/XMJzED/e842AkQjtqT1fygOOcfHtS+T0uC6jZa3/rc jXQxC X-Gm-Gg: AY/fxX7xthm7LbQIVAveyN1bH0UBBhWT2d2mHRWIFrgmxgJAOp2yDk2iViRQjiCS7/Y wWPJn9vBtViI1cVCbnIcAV++m8Z7MrbF2hcJaGWdlriwg6QOMtI0NjkrhL5CYaLbcSODR86FhMs lDR+zsq0SSfg5B9+Jm+eg6FjqYjbx7KXG8kjSIhtr7FmUhm2c5kUZnG6XoIE1wjVptIlrxREgTT tkN2xeBRkVa6GVX9+pJxd5c5f/o59QwGQ2zqaoPAFW7oHOxsSwcr27eLbogt5oGerjIDaLPUHqM JHd0QjafheqslpDAjo+mRSZBeQsnBSHTc+N330MnZMXK+5Suc5P7Dr2Rsmip9A2VYNQyU4jA01F SiZNmHFemvzpI3lLnBjxwkr8Hx6TXqxNlxpkTAjXxKb9eZGrW9tdUgkWUge8G8+vX3RyCTBuDXU qEqiZw3LE= X-Received: by 2002:a05:6830:2405:b0:7cf:db7e:2bf6 with SMTP id 46e09a7af769-7cfdee741ccmr100534a34.30.1768497514650; Thu, 15 Jan 2026 09:18:34 -0800 (PST) Received: from [192.168.1.102] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7cfdf2a696esm30708a34.21.2026.01.15.09.18.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jan 2026 09:18:34 -0800 (PST) Message-ID: <2d73aaa4-9718-4285-ab3f-85e1fa3b40fa@kernel.dk> Date: Thu, 15 Jan 2026 10:18:33 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] block: remove the boring judgment in blk_rq_map_bio_alloc() To: Chaohai Chen Cc: linux-kernel@vger.kernel.org References: <20260115114356.4167248-1-wdhh6@aliyun.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <20260115114356.4167248-1-wdhh6@aliyun.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/15/26 4:43 AM, Chaohai Chen wrote: > There is no need to check the return value of bio_alloc_bioset(). Boring judgement? I'm very confused, what on earth does that mean. > diff --git a/block/blk-map.c b/block/blk-map.c > index 4533094d9458..f95b07ec3b88 100644 > --- a/block/blk-map.c > +++ b/block/blk-map.c > @@ -46,14 +46,8 @@ static struct bio *blk_rq_map_bio_alloc(struct request *rq, > unsigned int nr_vecs, gfp_t gfp_mask) > { > struct block_device *bdev = rq->q->disk ? rq->q->disk->part0 : NULL; > - struct bio *bio; > > - bio = bio_alloc_bioset(bdev, nr_vecs, rq->cmd_flags, gfp_mask, > - &fs_bio_set); > - if (!bio) > - return NULL; > - > - return bio; > + return bio_alloc_bioset(bdev, nr_vecs, rq->cmd_flags, gfp_mask, &fs_bio_set); > } Presumably this means that nobody ever calls blk_rq_map_bio_alloc() without __GFP_WAIT set in gfp_mask? Because otherwise this would be broken. And this then further means that this should most likely be checked. All of this is absent from the commit message, which has zero details. -- Jens Axboe