From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77E403FE366 for ; Wed, 29 Apr 2026 13:41:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777470068; cv=none; b=ueaFdBwuaQZmVm2t1vrEl1WQ8JVMTPzM3+5SZZLFAlQdwaYwTM8iygHphkM/qK3muk/K+3coQTZbxl07oG1zhiVgEhHbiOC05BuFKlXnRwqJg6pCpfB17G88mSJdk7WNOZ0AlAtjpA4iM/MBAQaNwbOZ671CR7kbNzp4UaY+yps= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777470068; c=relaxed/simple; bh=qAZ16WjkXW8EaE4bAi9IdH+z9/TRRUTlzn3zZxZEVLw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j58XubUV568mOjTLOzJYp25nAd44oliItkKPPRfFjrUrlM8Gdk+asx0tWtcYK+CWE0MRjaJqBxYpv1fkGbWWysiD/Fh+vX9YqMss1aQuEOWsHxhpgKzGqbgjX3DGIYeo84r0l0VynrEfkb6Po9rJg1L+ZN260AcBiIHIUY7siKw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OKVVMajt; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OKVVMajt" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4891b0786beso91458295e9.1 for ; Wed, 29 Apr 2026 06:41:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777470059; x=1778074859; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SE1WBDEAJ1UYNmcfE47F7BEz7WO16H1bRtYL6mvQ6Xs=; b=OKVVMajtloHYxEnX2+J+ZSCy4yTiSNRho/lGJPvJh/Aral/GUR82G4qRfUS6qEWiGs ifsJfjsRdH9dzbx9fYmTrOkFj4JSfsBGYBECRsIjvxatPAinhCzqLKOhejOMUBZmC3aE ImuD6DAwDwnB3zw2i81tDLDckD6xGCkP2vvA5NmWlXx0n+o3CJqBNrldWQD5OqWru7tl Fngru0z1sVT6qsR/yrqgdk3XaQwgyVJpeNzGR/38PAxqzhgc38Xs3g6i79gb8zf4L3HA F+vTYCdg0pFBtCkdVDH5F0ApxusQCkmMTwhv/BQ3x8HT+Dmh2nOgY2zS2d/8POYyjbUl uEnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777470059; x=1778074859; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SE1WBDEAJ1UYNmcfE47F7BEz7WO16H1bRtYL6mvQ6Xs=; b=ddjdC0F2BjYj5cZN3tgpWsa6CfzX4QyYdKiIfWVNfj/fpB9Hn0ryyyt8tk3f6pBpI0 5RUSJnESyG5ItoXD8tmJu0r9yAf8H33k3v65mTOrAu9irCvfRXHd3tFonmwjPz/zbvfo 2TAMZrIgo+S/nk4ysljOcGfew1guBpAzHMd8sJZRgckBsHztSReKlRqdb0h0vcgiHycu w40pzB5uAsHCsWL6YLQeXGdVf0IfbPQlICtBNQrigIBHkjVSNmoeBV8S/lXRgf+iTd1w fv2Ho3Fv4Zy/AvANXf3VRsBWjMq1Bbhq23wA27G+lGrXu4E+wor0692aub0CG+iEhbEJ Yr3w== X-Forwarded-Encrypted: i=1; AFNElJ/bNDaG8FLMXpXAXgst53gS8YMMpoltFqCIaL/VBlp5jE5XntvCCduuyvJozw3Cag3cxejrYXRsE3ystU4=@vger.kernel.org X-Gm-Message-State: AOJu0YwrKe/Gj5ik0Q3g3/DpatnkgbxVtvqTLwIXZcgMulvsy6hWz/Z7 d4MJ3IUnMv6E3uQUSn8WG7Kau8Qd3qjpPr460B0lCTG7jIa50CbqO+ab X-Gm-Gg: AeBDieu471n/Y3cMyKQFdh2fbzyqx7H8jJ5y8inSqY9/I4Y//vbwpCdboFeywg6J5m1 9Ie5rWaYLFSbSoFeBxRZnkdfc7WSOXLXjqNemCIp1dEr3y0RaKn3+JEGWsCnYAg6UDF08RalOYc Op9CNy4V/h+mA/XImi1J+K1iO5qrSk6j5xgjA6xw+LJIv6rhPLAcyQM+xUKterXTy3DLoBsylRT MQXs7DpbjMBEeUeuyV8whPTubxgIZx9AcuJlfHI4bP0T/oQLBAtlilpJNx5kiQMAeAAhZIpzY+5 spdouXwjHvIMAPZ+FNAp6GNLIGZP+dh+O2NRCRE8FlO7nfheFi7ZkgsukRSVXdUZ/BdcpVPE+L/ yq+ghw2qwTW3qreZzFP11MfJAzdBr8wiz8KiI7MUoZQ4mKsHOgRzWK+sONQi7ie8+6EtBfyCrJG a0ChXoR8kdGxajiIt/f1o9Yla5TsCOg52rYqVZ0SnvTbMswlG2Ber1QA/sj1KnODSY0A1Cp2oZx pPARAhboA== X-Received: by 2002:a05:600c:4e4b:b0:488:be58:bb5b with SMTP id 5b1f17b1804b1-48a7b547375mr70268735e9.24.1777470059359; Wed, 29 Apr 2026 06:40:59 -0700 (PDT) Received: from ?IPV6:2001:861:3385:e20:f99c:d6cf:27e6:2b03? ([2001:861:3385:e20:f99c:d6cf:27e6:2b03]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48a7c57b579sm56656275e9.4.2026.04.29.06.40.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Apr 2026 06:40:58 -0700 (PDT) Message-ID: <2d81e7f6-b6e4-4e3e-bd75-315c696c003a@gmail.com> Date: Wed, 29 Apr 2026 15:40:28 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] drm/sti: remove bridge when sti_hda component_add fails To: Osama Abdelkader , luca.ceresoli@bootlin.com, Alain Volmat , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org References: <20260423200622.325076-1-osama.abdelkader@gmail.com> Content-Language: en-US From: =?UTF-8?Q?Rapha=C3=ABl_Gallais-Pou?= In-Reply-To: <20260423200622.325076-1-osama.abdelkader@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 4/23/26 22:06, Osama Abdelkader wrote: > Use devm_drm_bridge_add() so the bridge is released if probe fails after > registration, and drop the manual drm_bridge_remove() in remove(). > > Check the return value of devm_drm_bridge_add(). > > Signed-off-by: Osama Abdelkader > Fixes: d28726efc637 ("drm/sti: hda: add bridge before attaching") > Cc: stable@vger.kernel.org > --- Hi Osama, Acked-by: Raphaël Gallais-Pou Thanks, Best regards, Raphaël