Re: [PATCH V4 5/5] perf vendor events arm64: Add default tags for Hisi hip08 L1 metrics

Ian Rogers
2023-06-16T05:57:45Z

On Thu, Jun 15, 2023 at 8:15 PM <kan.liang@linux.intel.com> wrote:
>
> From: Kan Liang <kan.liang@linux.intel.com>
>
> Add the default tags for Hisi hip08 as well.
>
> Signed-off-by: Kan Liang <kan.liang@linux.intel.com>
> Cc: John Garry <john.g.garry@oracle.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
> .../arch/arm64/hisilicon/hip08/metrics.json | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
> index 6443a061e22a..6463531b9941 100644
> --- a/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
> +++ b/tools/perf/pmu-events/arch/arm64/hisilicon/hip08/metrics.json
> @@ -3,28 +3,32 @@
> "MetricExpr": "FETCH_BUBBLE / (4 * CPU_CYCLES)",
> "PublicDescription": "Frontend bound L1 topdown metric",
> "BriefDescription": "Frontend bound L1 topdown metric",
> - "MetricGroup": "TopDownL1",
> + "DefaultMetricgroupName": "TopDownL1",
> + "MetricGroup": "Default;TopDownL1",
> "MetricName": "frontend_bound"
> },
> {
> "MetricExpr": "(INST_SPEC - INST_RETIRED) / (4 * CPU_CYCLES)",
> "PublicDescription": "Bad Speculation L1 topdown metric",
> "BriefDescription": "Bad Speculation L1 topdown metric",
> - "MetricGroup": "TopDownL1",
> + "DefaultMetricgroupName": "TopDownL1",
> + "MetricGroup": "Default;TopDownL1",
> "MetricName": "bad_speculation"
> },
> {
> "MetricExpr": "INST_RETIRED / (CPU_CYCLES * 4)",
> "PublicDescription": "Retiring L1 topdown metric",
> "BriefDescription": "Retiring L1 topdown metric",
> - "MetricGroup": "TopDownL1",
> + "DefaultMetricgroupName": "TopDownL1",
> + "MetricGroup": "Default;TopDownL1",
> "MetricName": "retiring"
> },
> {
> "MetricExpr": "1 - (frontend_bound + bad_speculation + retiring)",
> "PublicDescription": "Backend Bound L1 topdown metric",
> "BriefDescription": "Backend Bound L1 topdown metric",
> - "MetricGroup": "TopDownL1",
> + "DefaultMetricgroupName": "TopDownL1",
> + "MetricGroup": "Default;TopDownL1",
> "MetricName": "backend_bound"
> },
> {
> --
> 2.35.1
>