From: Cosmin Tanislav <demonsingur@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: detach regmap from dev on regmap_exit
Date: Mon, 25 Nov 2024 22:44:06 +0200 [thread overview]
Message-ID: <2da70bdc-97d5-4bef-bb66-3becf40c54ec@gmail.com> (raw)
In-Reply-To: <3b35bd30-c4ca-459d-985e-d221a5cda2c8@sirena.org.uk>
On 11/25/24 2:22 PM, Mark Brown wrote:
> On Fri, Nov 22, 2024 at 05:16:30PM +0200, Cosmin Tanislav wrote:
>
>> +int regmap_detach_dev(struct device *dev, struct regmap *map)
>> +{
>> + if (!dev)
>> + return 0;
>> +
>> + return devres_release(dev, dev_get_regmap_release,
>> + dev_get_regmap_match, (void *)map->name);
>> +}
>> +EXPORT_SYMBOL_GPL(regmap_detach_dev);
>
> Why is this exported?
>
I only did it because regmap_attach_dev() was also exported.
I can make it static for V2.
>> @@ -1445,6 +1457,7 @@ void regmap_exit(struct regmap *map)
>> {
>> struct regmap_async *async;
>>
>> + regmap_detach_dev(map->dev, map);
>> regcache_exit(map);
>>
>> regmap_debugfs_exit(map);
>
> The one caller is in the same file so it can be static.
prev parent reply other threads:[~2024-11-25 20:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-22 15:16 [PATCH] regmap: detach regmap from dev on regmap_exit Cosmin Tanislav
2024-11-25 12:22 ` Mark Brown
2024-11-25 20:44 ` Cosmin Tanislav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2da70bdc-97d5-4bef-bb66-3becf40c54ec@gmail.com \
--to=demonsingur@gmail.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox