From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Raul E Rangel <rrangel@chromium.org>, Wolfram Sang <wsa@the-dreams.de>
Cc: Akshu.Agrawal@amd.com, Guenter Roeck <groeck@chromium.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
linux-kernel@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-i2c@vger.kernel.org, Benson Leung <bleung@chromium.org>
Subject: Re: [PATCH 1/4] i2c: i2c-cros-ec-tunnel: Pass ACPI node to i2c adapter
Date: Mon, 25 Nov 2019 17:06:26 +0100 [thread overview]
Message-ID: <2dcedacb-8d08-6a58-23af-e834ef9e80fd@collabora.com> (raw)
In-Reply-To: <20191121140830.1.Iae79baaa31014e8b1d8177bcfbcd41514af724f9@changeid>
Hi,
On 21/11/19 22:10, Raul E Rangel wrote:
> The I2C bus needs to share the same ACPI node as the tunnel device so
> that the I2C bus can be referenced from ACPI.
>
> Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Hmm, isn't this change the same as https://lkml.org/lkml/2019/11/21/208 ?
Should I assume this deprecates the one pointed above? Who is the author? Please
maintain the Signed-off chain.
Thanks,
Enric
> ---
> I would have added a Fixes annotation, but I wasn't able to find the
> hash for https://lore.kernel.org/patchwork/patch/1151436/.
>
> drivers/i2c/busses/i2c-cros-ec-tunnel.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/i2c-cros-ec-tunnel.c b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> index 958161c71985..ac2412755f0a 100644
> --- a/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> +++ b/drivers/i2c/busses/i2c-cros-ec-tunnel.c
> @@ -272,6 +272,7 @@ static int ec_i2c_probe(struct platform_device *pdev)
> bus->adap.algo_data = bus;
> bus->adap.dev.parent = &pdev->dev;
> bus->adap.dev.of_node = pdev->dev.of_node;
> + ACPI_COMPANION_SET(&bus->adap.dev, ACPI_COMPANION(&pdev->dev));
> bus->adap.retries = I2C_MAX_RETRIES;
>
> err = i2c_add_adapter(&bus->adap);
>
next prev parent reply other threads:[~2019-11-25 16:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 21:10 [PATCH 0/4] Convert cros-ec-i2c-tunnel to MFD Cell Raul E Rangel
2019-11-21 21:10 ` [PATCH 1/4] i2c: i2c-cros-ec-tunnel: Pass ACPI node to i2c adapter Raul E Rangel
2019-11-25 16:06 ` Enric Balletbo i Serra [this message]
2019-11-25 18:05 ` Raul Rangel
2020-01-31 7:48 ` Wolfram Sang
2019-11-21 21:10 ` [PATCH 2/4] i2c: i2c-cros-ec-tunnel: Fix ACPI identifier Raul E Rangel
2019-11-25 16:23 ` Enric Balletbo i Serra
2019-11-25 18:12 ` Raul Rangel
2020-01-31 7:48 ` Wolfram Sang
2019-11-21 21:10 ` [PATCH 3/4] platform/chrome: cros_ec: Pass firmware node to MFD device Raul E Rangel
2019-11-25 16:30 ` Enric Balletbo i Serra
2019-11-21 21:10 ` [PATCH 4/4] platform/chrome: i2c: i2c-cros-ec-tunnel: Convert i2c tunnel to MFD Cell Raul E Rangel
2019-11-21 21:40 ` Guenter Roeck
2019-11-21 21:49 ` Raul Rangel
2019-11-22 8:03 ` Lee Jones
2019-11-22 10:42 ` Guenter Roeck
2019-11-25 16:51 ` Enric Balletbo i Serra
2019-11-25 19:38 ` Raul Rangel
2019-12-09 13:17 ` Lee Jones
2019-12-09 14:41 ` Enric Balletbo i Serra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dcedacb-8d08-6a58-23af-e834ef9e80fd@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=Akshu.Agrawal@amd.com \
--cc=bleung@chromium.org \
--cc=cw00.choi@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rrangel@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox