From: Krzysztof Kozlowski <krzk@kernel.org>
To: Daniel Schultz <d.schultz@phytec.de>,
nm@ti.com, vigneshr@ti.com, kristo@kernel.org, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: w.egorov@phytec.de, upstream@lists.phytec.de
Subject: Re: [PATCH] arm64: dts: ti: am64-phyboard-electra: Add DT overlay for X27 connector
Date: Mon, 27 Jan 2025 18:24:11 +0100 [thread overview]
Message-ID: <2dd9bffa-17d5-4635-b2da-15f59cf07590@kernel.org> (raw)
In-Reply-To: <20250127065756.3086450-1-d.schultz@phytec.de>
On 27/01/2025 07:57, Daniel Schultz wrote:
> +&main_spi1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&main_spi1_pins_default>;
> + ti,pindir-d0-out-d1-in = <1>;
> + status = "okay";
> +
> + spidev@0 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> + compatible = "rohm,dh2228fv";
That's not the device you have there. You cannot use other compatibles.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-27 17:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 6:57 [PATCH] arm64: dts: ti: am64-phyboard-electra: Add DT overlay for X27 connector Daniel Schultz
2025-01-27 17:24 ` Krzysztof Kozlowski [this message]
2025-01-28 8:43 ` Daniel Schultz
2025-01-28 9:02 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2dd9bffa-17d5-4635-b2da-15f59cf07590@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=d.schultz@phytec.de \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=upstream@lists.phytec.de \
--cc=vigneshr@ti.com \
--cc=w.egorov@phytec.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox