RE: [PATCH net-next 5/5] dt-bindings: net: Add bindings for the ADIN1140

["Regus, Ciprian" <Ciprian.Regus@analog.com>]

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Sunday, May 3, 2026 4:07 AM
> To: Regus, Ciprian <Ciprian.Regus@analog.com>
> Cc: Parthiban Veerasooran <parthiban.veerasooran@microchip.com>;
> Andrew Lunn <andrew+netdev@lunn.ch>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub
> Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Simon
> Horman <horms@kernel.org>; Jonathan Corbet <corbet@lwn.net>; Shuah
> Khan <skhan@linuxfoundation.org>; Heiner Kallweit
> <hkallweit1@gmail.com>; Russell King <linux@armlinux.org.uk>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor
> Dooley <conor+dt@kernel.org>; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-doc@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH net-next 5/5] dt-bindings: net: Add bindings for the
> ADIN1140
> 
> [External]
> 
> > +  The ADIN1140 (also called AD3306) is a low power single port
> > +  10BASE-T1S MAC-PHY. It integrates an Ethernet PHY with a MAC
> > +  and all the associated analog circuitry.
> > +  The device implements the Open Alliance TC6 10BASE-T1x MAC-PHY
> 
> The device _tries_ to implements the Open Alliance TC6 10BASE-T1x MAC-
> PHY.

Will update in v2.

> 
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    spi {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        ethernet@0 {
> > +            compatible = "adi,adin1140";
> > +            reg = <0>;
> > +            spi-max-frequency = <23000000>;
> > +
> > +            interrupt-parent = <&gpio>;
> > +            interrupts = <6 IRQ_TYPE_EDGE_FALLING>;
> 
> Table 1: OPEN serial 10BASE-T1x Interface Pin Definition
> 
> IRQn MAC-PHY Interrupt Request (Active Low)
> 
> Or is this something else which the device gets wrong?

The device generates interrupts correctly (the IRQ signal remains
asserted while there are active interrupt conditions that have not
been cleared yet). The oa_tc6 driver requests the interrupt with
the IRQF_TRIGGER_FALLING flag set, so the DT flag will be overridden
and the behavior remains the same.

However, the devicetree shouldn't care about this. I'll update to
IRQ_TYPE_LEVEL_LOW in v2.

> 
> 	Andrew