public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chengming Zhou <chengming.zhou@linux.dev>
To: ericvh@kernel.org, lucho@ionkov.net, asmadeus@codewreck.org,
	linux_oss@crudebyte.com
Cc: v9fs@lists.linux.dev, linux-kernel@vger.kernel.org,
	vbabka@suse.cz, roman.gushchin@linux.dev,
	Xiongwei.Song@windriver.com
Subject: Re: [PATCH] 9p: remove SLAB_MEM_SPREAD flag usage
Date: Mon, 26 Feb 2024 10:51:00 +0800	[thread overview]
Message-ID: <2de0d872-0e05-4fbb-8291-0c60487ccd8d@linux.dev> (raw)
In-Reply-To: <20240224134617.829016-1-chengming.zhou@linux.dev>

On 2024/2/24 21:46, chengming.zhou@linux.dev wrote:
> From: Chengming Zhou <zhouchengming@bytedance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/

Thanks!

> 
> Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
> ---
>  fs/9p/v9fs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/9p/v9fs.c b/fs/9p/v9fs.c
> index 61dbe52bb3a3..281a1ed03a04 100644
> --- a/fs/9p/v9fs.c
> +++ b/fs/9p/v9fs.c
> @@ -637,7 +637,7 @@ static int v9fs_init_inode_cache(void)
>  	v9fs_inode_cache = kmem_cache_create("v9fs_inode_cache",
>  					  sizeof(struct v9fs_inode),
>  					  0, (SLAB_RECLAIM_ACCOUNT|
> -					      SLAB_MEM_SPREAD|SLAB_ACCOUNT),
> +					      SLAB_ACCOUNT),
>  					  v9fs_inode_init_once);
>  	if (!v9fs_inode_cache)
>  		return -ENOMEM;

  reply	other threads:[~2024-02-26  2:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-24 13:46 [PATCH] 9p: remove SLAB_MEM_SPREAD flag usage chengming.zhou
2024-02-26  2:51 ` Chengming Zhou [this message]
2024-03-04 13:10   ` asmadeus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2de0d872-0e05-4fbb-8291-0c60487ccd8d@linux.dev \
    --to=chengming.zhou@linux.dev \
    --cc=Xiongwei.Song@windriver.com \
    --cc=asmadeus@codewreck.org \
    --cc=ericvh@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux_oss@crudebyte.com \
    --cc=lucho@ionkov.net \
    --cc=roman.gushchin@linux.dev \
    --cc=v9fs@lists.linux.dev \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox