From: Eric Huang <jinhuieric.huang@amd.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "Felix Kuehling" <Felix.Kuehling@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
"Kent Russell" <kent.russell@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] drm/amdkfd: Fix kfd_smi_event_process()
Date: Tue, 15 Apr 2025 09:35:27 -0400 [thread overview]
Message-ID: <2e066edc-e279-4252-ba67-b4be2b462084@amd.com> (raw)
In-Reply-To: <Z_44oq-aSZOsvxTN@stanley.mountain>
Thanks for the fix, I had the same patch submitted yesterday.
Regards,
Eric
On 2025-04-15 06:44, Dan Carpenter wrote:
> The "pdd->drm_priv" NULL check is reversed so it will lead to a NULL
> dereference on the next line.
>
> Fixes: 4172b556fd5b ("drm/amdkfd: add smi events for process start and end")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> index 727a4ce29fe6..c27fd7aec1c3 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_smi_events.c
> @@ -350,7 +350,7 @@ void kfd_smi_event_process(struct kfd_process_device *pdd, bool start)
> struct amdgpu_task_info *task_info;
> struct amdgpu_vm *avm;
>
> - if (pdd->drm_priv)
> + if (!pdd->drm_priv)
> return;
>
> avm = drm_priv_to_vm(pdd->drm_priv);
prev parent reply other threads:[~2025-04-15 13:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-15 10:44 [PATCH next] drm/amdkfd: Fix kfd_smi_event_process() Dan Carpenter
2025-04-15 13:35 ` Eric Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e066edc-e279-4252-ba67-b4be2b462084@amd.com \
--to=jinhuieric.huang@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kent.russell@amd.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox