Re: [PATCH v3] erofs: support deflate decompress by using Intel QAT

[Gao Xiang <hsiangkao@linux.alibaba.com>]

Hi Eric,

On 2025/5/17 00:38, Eric Biggers wrote:
> On Fri, May 16, 2025 at 04:26:34AM -0400, Bo Liu wrote:
>> +config EROFS_FS_ZIP_CRYPTO
>> +	bool "EROFS hardware decompression support (crypto interface)"
>> +	depends on EROFS_FS_ZIP
>> +	help
>> +	  Saying Y here includes support for reading EROFS file systems
>> +	  containing crypto compressed data.  It gives better decompression
>> +	  speed than the software-implemented compression, and it costs
>> +	  lower CPU overhead.
>> +
>> +	  Crypto support is an experimental feature for now and so most
>> +	  file systems will be readable without selecting this option.
>> +
>> +	  If unsure, say N.
> 
> I recommend not including the word "crypto" in any user facing part of this.
> 
> Compression algorithms are not cryptographic algorithms.  The fact that the
> interface to access hardware compression accelerators is currently the "Crypto
> API" is an implementation quirk.  It could be a different interface in the
> future.
> 
> Call it something clear like "hardware decompression".

Totally agreed on this since it's just an implementation detail,
and I will try to make some extra time to polish this commit myself
to fix some minor issues later.

Thanks,
Gao Xiang


> 
> - Eric