From: Antti Palosaari <crope@iki.fi>
To: Stefan Bruens <stefan.bruens@rwth-aachen.de>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v2 3/3] [media] dvbsky: MyGica T230C support
Date: Thu, 16 Feb 2017 10:54:54 +0200 [thread overview]
Message-ID: <2e741734-86d8-85df-b4f5-e47d99c6d0af@iki.fi> (raw)
In-Reply-To: <557ce694-5edd-169a-7062-da249137f2ed@iki.fi>
On 02/16/2017 10:48 AM, Antti Palosaari wrote:
> On 02/16/2017 01:31 AM, Stefan Bruens wrote:
>>>> + /* attach demod */
>>>> + memset(&si2168_config, 0, sizeof(si2168_config));
>>>
>>> prefer sizeof dst
>>
>> You mean sizeof(struct si2168_config) ?
>
> yeah. See chapter 14 from kernel coding style documentation, it handles
> issue slightly.
argh, I looked wrong! It is *correct*, do not change it. It is just as
it should. Sorry about noise.
regards
Antti
--
http://palosaari.fi/
prev parent reply other threads:[~2017-02-16 8:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170215015122.4647-1-stefan.bruens@rwth-aachen.de>
2017-02-15 1:51 ` [PATCH v2 1/3] [media] si2157: Add support for Si2141-A10 Stefan Brüns
2017-02-15 1:51 ` [PATCH v2 2/3] [media] si2168: add support for Si2168-D60 Stefan Brüns
2017-02-15 1:51 ` [PATCH v2 3/3] [media] dvbsky: MyGica T230C support Stefan Brüns
2017-02-15 8:27 ` Antti Palosaari
2017-02-15 23:31 ` Stefan Bruens
2017-02-16 8:48 ` Antti Palosaari
2017-02-16 8:54 ` Antti Palosaari [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e741734-86d8-85df-b4f5-e47d99c6d0af@iki.fi \
--to=crope@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stefan.bruens@rwth-aachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox