From: Sohil Mehta <sohil.mehta@intel.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: <x86@kernel.org>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Uros Bizjak <ubizjak@gmail.com>,
Sandipan Das <sandipan.das@amd.com>,
Sean Christopherson <seanjc@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Vegard Nossum <vegard.nossum@oracle.com>,
Tony Luck <tony.luck@intel.com>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Nikolay Borisov <nik.borisov@suse.com>,
Eric Biggers <ebiggers@google.com>, Xin Li <xin3.li@intel.com>,
"Alexander Shishkin" <alexander.shishkin@intel.com>,
Kirill Shutemov <kirill.shutemov@linux.intel.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] x86/cpufeature: Warn about unmet feature dependencies
Date: Thu, 13 Mar 2025 09:35:25 -0700 [thread overview]
Message-ID: <2e9900e5-e25a-4e53-acb2-d71247cd497e@intel.com> (raw)
In-Reply-To: <Z9KwG9t2OVhoapZc@gmail.com>
On 3/13/2025 3:14 AM, Ingo Molnar wrote:
>>> I'd make this a bit less passive-aggressive, something like:
>>>
>>> x86 CPU feature dependency check failure: CPU%d has '%s' enabled but '%s' disabled. Kernel might be fine, but no guarantees.
>>>
>
...
> Yeah, so I really wanted to sneak in the 'dependency' part - because
> it's not necessarily obvious from the text, and most syslog readers
> will have no idea what it's all about.
>
> I don't think line length should be an issue for a message we don't
> expect to trigger normally. Clarity is more important.
>
Sounds good, I'll use the one you proposed as-is. Will send a new
(hopefully final) revision soon with the changes.
> Thanks,
>
> Ingo
prev parent reply other threads:[~2025-03-13 16:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 0:02 [PATCH v5] x86/cpufeature: Warn about unmet feature dependencies Sohil Mehta
2025-03-07 11:55 ` Ingo Molnar
2025-03-12 23:16 ` Sohil Mehta
2025-03-13 10:14 ` Ingo Molnar
2025-03-13 16:35 ` Sohil Mehta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9900e5-e25a-4e53-acb2-d71247cd497e@intel.com \
--to=sohil.mehta@intel.com \
--cc=alexander.shishkin@intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=ebiggers@google.com \
--cc=hpa@zytor.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=nik.borisov@suse.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=sandipan.das@amd.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=ubizjak@gmail.com \
--cc=vegard.nossum@oracle.com \
--cc=x86@kernel.org \
--cc=xin3.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox