From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D99B1D5CC7 for ; Mon, 6 Jan 2025 08:29:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736152143; cv=none; b=t6BBw0GJpBNIk/XJlLGtPWOg5S38JcL+izvP/14Sph1ovlELJ3GRZOTF9Nu6402c9SfCrrxYOO2+xFjYmT0dqgfcTcJ5OkyJZP+yIpy1JH5N5rA8Qz5OGN06MLu+1rPRVf9N08aNftMkHfa5R9cmgP7DGt4nbppv4u63pdj4sJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736152143; c=relaxed/simple; bh=M5hUhat/bAuUMc8q55/KJv/JnbBudv+hp3ctOvU0WHw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KS3rryY8JyT4BBqTwfS0LepC7iIzHGQIUpOJ8f2S6f33GpT6qdD4g77NXalsgp+heE0i7ebehbMfvNBXsFjUu80rVdf3Z4TYwW9KD4d91a/DE/mitNbDZTTpGC/zh4oySrRyeamym5sRKpgjCf+INaHkq7dZvUjY2wU/5Ul/RtU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y1F7NlJ9; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y1F7NlJ9" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3863494591bso7238658f8f.1 for ; Mon, 06 Jan 2025 00:29:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736152139; x=1736756939; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UDxsIOaiaJxaktdlNg4I9YAwK+RVYjasmpkTXj+LKDM=; b=y1F7NlJ9eAf1JnvtYYiRCDZg/xQTNaoT1KgNbLVk7goZvX2x5WNsng4KCyqX/0Ya/l AK5KoQZB65lgyXX0lWjz9nHP1RtcJtrT9vNFqqVjw5bk2xoJ/FuB/Qya11ElFJHYtIHi GuRh5jGWMqkyqF0WAgwDJL2xCLfsQU7ZLdFdqZ9RSmHcTAGJ4SERnQ6ofIGpJJsZsTGW ovSQ46AxKzwKBQIYIrXvWWf78h72uBThdHSS4tBzt9Ey9RQdnLVQUxVy6vXrbwBAodhM 10G45phYmfajxoDvTdInTGXPd8Q4nKIKcIdeSfdnXpW9iEo8AYB3HwLCBICTNByvZtpL +WNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736152139; x=1736756939; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UDxsIOaiaJxaktdlNg4I9YAwK+RVYjasmpkTXj+LKDM=; b=N81otG+1aOyyhdyHBFDxWiMc1+4dCD41HyP8zL6vaySmYpqj4jc/GRelpdb2brtsKe deLY1yv36V28B0IS95vJDmQvbXRjProITU4477gV8kbffYxKRAdNbu6HUL0qmwjo8gSt KoldWvpPZ61DwQYtcrMndmaYVaLBaOxdJOMKI7nS57N7P0w/Co8LZYnaZO2Qy2EoVQc3 YcZmMe/d9b0Hg9ES12zF7b/W6a9eWWpYj+ntDk0Z+prLuPaKJ3+qdnsMaKMcHQybO9l3 FlglA4ayVxS6jfiK+luK4jR6FYA6hl2iaWMSHDTYCC2jyv2HXlhqlWlUnyqpVTZzo+IA KFgQ== X-Forwarded-Encrypted: i=1; AJvYcCVE8Z+JgYnAGmsI7Rel5ehZ2/A4FmeOH/QsPErH+EMFWje3Fwd/KffLhzaGzUKA7PZ0jKygqUxEkoqQQuk=@vger.kernel.org X-Gm-Message-State: AOJu0Yzm9YIjkoRV8ej2f0rFNWcBpsxiDGbRvCtrXjuenrr3G53Aczu2 kkyuXGvhis6r0sXUYKXcDHtsLIUgbdFpotBe4/8W7J6nFUtu4o9llDgdQfndPHg= X-Gm-Gg: ASbGncttTwWLbS1KFuiYnNL3sD9UAaIKM23M32C3HOdLYKjHVgaShV+MPQulMDIZ7oZ w+pKBQv/aClXp6F7NM5IkdfJrNnFdlfZ7wim60HBP7uBXQcsr8MHECkpkRu0jIjoDcGQHjbM7aH Z7RJY6BqGOIpTT7jAt55pcWjVD6i5gwYTd8JWWz8pTcaOScAiQvUYmf5M/Cwmq9DUoQeYCxDSLx W1gF9v/EeVQ+t0BlnDV31R7tTSldFEZhD9AztYlQfjsHS3RLilYemH/uTZANQ== X-Google-Smtp-Source: AGHT+IHJZErPKbdmzIpBYh1QikYHGJ3nST5M+FNfn5aNkfTTsqIMFPTb13dTvpPJsfRjBNoKswvCsA== X-Received: by 2002:a5d:6486:0:b0:386:5b2:a9d9 with SMTP id ffacd0b85a97d-38a22408e42mr55544487f8f.53.1736152139171; Mon, 06 Jan 2025 00:28:59 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c848a47sm46737989f8f.62.2025.01.06.00.28.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jan 2025 00:28:58 -0800 (PST) Date: Mon, 6 Jan 2025 11:28:55 +0300 From: Dan Carpenter To: Laurentiu Palcu Cc: Niklas =?iso-8859-1?Q?S=F6derlund?= , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 1/3] staging: media: max96712: fix typo Message-ID: <2e9a2faa-29c2-413f-aaa9-c8f2dfced28f@stanley.mountain> References: <20241219150644.64507-1-laurentiu.palcu@oss.nxp.com> <20241219150644.64507-2-laurentiu.palcu@oss.nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241219150644.64507-2-laurentiu.palcu@oss.nxp.com> On Thu, Dec 19, 2024 at 05:06:41PM +0200, Laurentiu Palcu wrote: > Fix a typo in VS_LOW expression. > > Signed-off-by: Laurentiu Palcu > --- > drivers/staging/media/max96712/max96712.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/max96712/max96712.c b/drivers/staging/media/max96712/max96712.c > index 0751b2e048958..5228f9ec60859 100644 > --- a/drivers/staging/media/max96712/max96712.c > +++ b/drivers/staging/media/max96712/max96712.c > @@ -182,7 +182,7 @@ static void max96712_pattern_enable(struct max96712_priv *priv, bool enable) > max96712_write_bulk_value(priv, 0x1052, 0, 3); > max96712_write_bulk_value(priv, 0x1055, v_sw * h_tot, 3); > max96712_write_bulk_value(priv, 0x1058, > - (v_active + v_fp + + v_bp) * h_tot, 3); > + (v_active + v_fp + v_bp) * h_tot, 3); Huh. I had expected this would be a bug in some way, but it actually works fine. #MysteriesOfC regards, dan carpenter