Re: [PATCH net-next v2 3/8] net/mlx5: HWS, Refactor and export rule skip logic

[Yevgeny Kliteynik <kliteyn@nvidia.com>]

On 25-Jun-25 12:45, Simon Horman wrote:
> On Wed, Jun 25, 2025 at 03:35:52AM +0300, Yevgeny Kliteynik wrote:
>> Hi Simon,
>> Thanks for reviewing the patches!
>>
>> On 24-Jun-25 21:38, Simon Horman wrote:
>>> On Sun, Jun 22, 2025 at 08:22:21PM +0300, Mark Bloch wrote:
>>>> From: Vlad Dogaru <vdogaru@nvidia.com>
>>>>
>>>> The bwc layer will use `mlx5hws_rule_skip` to keep track of numbers of
>>>> RX and TX rules individually, so export this function for future usage.
>>>>
>>>> While we're in there, reduce nesting by adding a couple of early return
>>>> statements.
>>>
>>> I'm all for reducing nesting. But this patch has two distinct changes.
>>> Please consider splitting it into two patches.
>>
>> Not sure I'd send the refactor thing alone - it isn't worth the effort
>> IMHO... But since I'm already in here - sure, will sent it in a separate
>> patch.
> 
> FWIIW, I think the refactor is fine in the context of this patchset.
> But I do feel that it being a separate patch within the patchset is best.

Ack, thanks