From: Jiri Slaby <jirislaby@kernel.org>
To: keescook@chromium.org
Cc: linux-kernel@vger.kernel.org, Andrei Vagin <avagin@google.com>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: Re: [PATCH] perf/benchmark: fix seccom_unotify benchmark for 32-bit
Date: Tue, 17 Oct 2023 10:30:57 +0200 [thread overview]
Message-ID: <2f09184f-c7dc-45f4-a398-e1194ecf7a47@kernel.org> (raw)
In-Reply-To: <20231017082952.31510-1-jirislaby@kernel.org>
Ignore this one, I mangled authorship.
On 17. 10. 23, 10:29, Jiri Slaby (SUSE) wrote:
> From: Andrei Vagin <avagin@google.com>
>
> Commit 7d5cb68af638 (perf/benchmark: add a new benchmark for
> seccom_unotify) added a reference to __NR_seccomp into perf. This is
> fine as it added also a definition of __NR_seccomp for 64-bit. But it
> failed to do so for 32-bit as instead of ifndef, ifdef was used.
>
> Fix this typo (so fix the build of perf on 32-bit).
>
> Fixes: 7d5cb68af638 (perf/benchmark: add a new benchmark for seccom_unotify)
> Cc: Andrei Vagin <avagin@google.com>
> Cc: "Peter Zijlstra (Intel)" <peterz@infradead.org>
> Cc: Kees Cook <keescook@chromium.org>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> ---
> tools/arch/x86/include/uapi/asm/unistd_32.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/arch/x86/include/uapi/asm/unistd_32.h b/tools/arch/x86/include/uapi/asm/unistd_32.h
> index 4798f9d18fe8..9de35df1afc3 100644
> --- a/tools/arch/x86/include/uapi/asm/unistd_32.h
> +++ b/tools/arch/x86/include/uapi/asm/unistd_32.h
> @@ -26,6 +26,6 @@
> #ifndef __NR_setns
> #define __NR_setns 346
> #endif
> -#ifdef __NR_seccomp
> +#ifndef __NR_seccomp
> #define __NR_seccomp 354
> #endif
--
js
suse labs
next prev parent reply other threads:[~2023-10-17 8:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 8:29 [PATCH] perf/benchmark: fix seccom_unotify benchmark for 32-bit Jiri Slaby (SUSE)
2023-10-17 8:30 ` Jiri Slaby [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-17 8:30 Jiri Slaby (SUSE)
2023-10-17 16:51 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f09184f-c7dc-45f4-a398-e1194ecf7a47@kernel.org \
--to=jirislaby@kernel.org \
--cc=avagin@google.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox