From: Heiner Kallweit <hkallweit1@gmail.com>
To: Asmaa Mnebhi <asmaa@nvidia.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"marek.mojik@nic.cz" <marek.mojik@nic.cz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: David Thompson <davthompson@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] net: phy: micrel: Add workaround for incomplete autonegotiation
Date: Thu, 28 Dec 2023 15:09:57 +0100 [thread overview]
Message-ID: <2f1e9892-261d-4b5f-9fdd-b0f852e90ea6@gmail.com> (raw)
In-Reply-To: <CH2PR12MB38952DAF6D1BD4CE6831EED1D79EA@CH2PR12MB3895.namprd12.prod.outlook.com>
On 28.12.2023 14:37, Asmaa Mnebhi wrote:
> > On 12/28/2023 12:16 AM, Asmaa Mnebhi wrote:
>>> Very rarely, the KSZ9031 fails to complete autonegotiation although it
>>> was initiated via phy_start(). As a result, the link stays down.
>>> Restarting autonegotiation when in this state solves the issue.
>>>
>>> Signed-off-by: Asmaa Mnebhi <asmaa@nvidia.com>
>>
>> Is there a Micrel errata associated with this work around that could be
>> referenced here?
>
> Hi Florian,
>
> No there isn’t. This is based on observations and comparison with the behavior and testing of other PHYs. For example, we don’t see this issue with the Vitesse PHY.
>
The Microchip KSZ9031 errata documentation lists few link-related errata.
May any of these be relevant in your case? If not, please check with Microchip.
KSZ9031 isn't new, and most likely we would have seen such reports before,
if there's an actual issue.
I'd like to avoid that we add code to work around an issue that is specific
to your setup.
> Thanks.
> Asmaa
next prev parent reply other threads:[~2023-12-28 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 23:16 [PATCH v2 1/1] net: phy: micrel: Add workaround for incomplete autonegotiation Asmaa Mnebhi
2023-12-28 8:43 ` Florian Fainelli
2023-12-28 13:37 ` Asmaa Mnebhi
2023-12-28 14:09 ` Heiner Kallweit [this message]
2023-12-28 21:21 ` Asmaa Mnebhi
2023-12-28 14:17 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f1e9892-261d-4b5f-9fdd-b0f852e90ea6@gmail.com \
--to=hkallweit1@gmail.com \
--cc=asmaa@nvidia.com \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.mojik@nic.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox