From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751675AbdBATFT (ORCPT ); Wed, 1 Feb 2017 14:05:19 -0500 Received: from mail-pf0-f193.google.com ([209.85.192.193]:36422 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751502AbdBATFR (ORCPT ); Wed, 1 Feb 2017 14:05:17 -0500 Subject: Re: [PATCH] net: phy: dp83867: Port mirroring support in the DP83867 TI's PHY driver To: Andrew Lunn , Lukasz Majewski References: <1485960215-5148-1-git-send-email-lukma@denx.de> <20170201171610.GC7395@lunn.ch> Cc: Rob Herring , Mark Rutland , "David S. Miller" , Mugunthan V N , Karicheri Muralidharan , linux-kernel@vger.kernel.org, Eric Engestrom , netdev@vger.kernel.org, Kishon Vijay Abraham I , Grygorii Strashko , devicetree@vger.kernel.org From: Florian Fainelli Message-ID: <2f3766f0-42df-6aab-dda1-14022c57fb30@gmail.com> Date: Wed, 1 Feb 2017 11:05:12 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170201171610.GC7395@lunn.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/01/2017 09:16 AM, Andrew Lunn wrote: > On Wed, Feb 01, 2017 at 03:43:35PM +0100, Lukasz Majewski wrote: >> This patch adds support for enabling or disabling the port mirroring >> feature of the DP83867 TI's PHY device. >> >> One use case is when bootstrap configuration enables this feature (because >> of e.g. LED wiring) so then one needs to disable it in software >> (u-boot/Linux). > > Hi Lukasz > > How does this differ from "enet-phy-lane-swap"? Same here, I am confused about what port mirroring could be meaning here and if we can find a better way to describe what is being added. Thanks! -- Florian