From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0BE74C9D for ; Fri, 5 Sep 2025 14:39:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083197; cv=none; b=V35cElHQ9GikRzIByYUVfBwrJQxrlKeu7KEjtxKE6sed0we7s80tRenaDOHjVniO9cFdbDZFTrSwcmuzFrb9+gVVJUBFcTOngimJqAVhEgApN94rlxmLFpPH0ZbiqrIXnA7aCslBx6jmNCnFec54msSNi9LWq+Gdhy5MdAdiXGg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757083197; c=relaxed/simple; bh=BOZsvUInyvKbT3yclcvKoWo6UbTAmuN/tpY7gOhMPLA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ME86qSIoE0rVWCwEGzeqIyLU+IfgT4MLRpFdokDZIPSbfawImciuONDeTGxSEv2rgzSWmf5tTEyyiEsuKNKRpYt2yojiE/SOab/qRyjrPRVx6z3jM0nCxFCaeBZ9f8PDTJveK9oTrAgGZrc3WNgnoedOhh2c7C/fmvdRgHJ6TKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Yg24swdk; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Yg24swdk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757083194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aIT9xzzc+wUHcoSXTn8cF4h16Jg9VDVb8x+KwFayKkE=; b=Yg24swdkE3HQzu7gWtfohCiBhK8FUDYyxysBWTxt7SU4/KuCeqfTonOJuMLyHj6mz7rt0t tXse92TYT7tR6KHKdcZtZGTFKsjShAJMr9aDP1lWqROcjaVfK7M+mL9ekfCaXR92kisWlV CmuwMmHqB4TRuakHZrAi6To0He2egBU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-677-sgQHZYlBMCmPFDZA-FRCxg-1; Fri, 05 Sep 2025 10:39:53 -0400 X-MC-Unique: sgQHZYlBMCmPFDZA-FRCxg-1 X-Mimecast-MFC-AGG-ID: sgQHZYlBMCmPFDZA-FRCxg_1757083193 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-45cb4f23156so12620275e9.2 for ; Fri, 05 Sep 2025 07:39:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757083192; x=1757687992; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aIT9xzzc+wUHcoSXTn8cF4h16Jg9VDVb8x+KwFayKkE=; b=vgn7KB6f5qoIPC0AXUjS3IeL6Pr9joRbYlf7f1ZID25nfKhawFZr2+IkcxgPHoXHLH lBbQmKDBI5nPTHAvn+Z/ru9k/LiuJrV1vdgict6hosqJuyu+RAxXJppUybyZxp4Yha9/ tO+MH3LuRkHf4fynt6ryNsFKgnUiVa8SHutb8mtWAJnL1psoGrDqaV5Ki3g2z2Gtamaq tnrsNayfsawiLOGXS2O+BFchrUiVrikSU2e8n3LZmK+IhOQSdxGSYNv/CcSdG37sq4GY FdcT6HQu0nEkdISPCHwhIPLpe23K5hCyvQQ8kIbTdeQd1iXtqqesSszDt2MU5qfeGszX NsNA== X-Gm-Message-State: AOJu0YzvkG3keCsFXESsEuQfhJBGiNP3hOypG/1UikFM6nymfUHWG5nT Fw/li0Qj4bNpTFSq77tm4eeYZ6OtTpImB7RZWOCXTHubNbLWNT0ShBw3o2RVgw2i+v4yBpFC9C/ /xjbfvHxxZAwpkAJ5w5cedDLPSrbiNT7qVXESlJMF0cgrifzDsEwulYoeiHLg0wE5wQ== X-Gm-Gg: ASbGncvxLCgyPd+sxGID/K0got2b1OGNYvo18kuwtxSdcwQMY2+ldaUceIq0dnRldtv OMAj9S10au/CWSeQtd83fSrVl0+ACIXogoxpbrdmrh3MMeKaJZDlBwtQeziHA0n/h/I5EUC4Hl8 U5OO7rIYf+XxXNbzbD+zFdBzlJM6yB4LDBF63x6pAA+Hni8K/j+nN4MQVa5A9QTLdIIDXv0MEgX QFZ3Zu7s9PpSqeXrFR4tiVmKg8B5WIsunNjlHFTY5jFIMtyLWofGRdmxZnpi9Am8DZzzNPoBnX8 kHv2UY58LsuogvqoF2ngHgUcMu6g+d5L9Vkdfzlz4eF92eQotzjDDi1TKor9GtEyblN8jT4STk8 0VghaRvd/eIPlxueVJt6rVdNWqM6oYuALIMVLTCz89VKWjygvOFb0MTny X-Received: by 2002:a05:600c:c1c8:10b0:45b:8600:2bcb with SMTP id 5b1f17b1804b1-45b86002ceemr144363215e9.7.1757083192409; Fri, 05 Sep 2025 07:39:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG26zcOGnTmxYKa5prpQ7Q60KpZl8OLelQjav2gH1ZzrBU5kkMMVuaTq4kp2txxfMeIMOp07A== X-Received: by 2002:a05:600c:c1c8:10b0:45b:8600:2bcb with SMTP id 5b1f17b1804b1-45b86002ceemr144362905e9.7.1757083191951; Fri, 05 Sep 2025 07:39:51 -0700 (PDT) Received: from ?IPV6:2003:d8:2f4d:e00:298:59cc:2514:52? (p200300d82f4d0e00029859cc25140052.dip0.t-ipconnect.de. [2003:d8:2f4d:e00:298:59cc:2514:52]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45dd0869b33sm84743155e9.9.2025.09.05.07.39.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 05 Sep 2025 07:39:51 -0700 (PDT) Message-ID: <2f4141b3-bd66-415d-b2ff-00544b03b908@redhat.com> Date: Fri, 5 Sep 2025 16:39:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm/huge_memory: fix shrinking of all-zero THPs with max_ptes_none default To: Zi Yan Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Usama Arif References: <20250905141137.3529867-1-david@redhat.com> <7B0B1E09-5083-449F-851D-FD63D32D2B3D@nvidia.com> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <7B0B1E09-5083-449F-851D-FD63D32D2B3D@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 05.09.25 16:37, Zi Yan wrote: > On 5 Sep 2025, at 10:11, David Hildenbrand wrote: > >> We added an early exit in thp_underused(), probably to avoid scanning >> pages when there is no chance for success. >> >> However, assume we have max_ptes_none = 511 (default). >> >> Nothing should stop us from freeing all pages part of a THP that >> is completely zero (512) and khugepaged will for sure not try to >> instantiate a THP in that case (512 shared zeropages). >> >> This can just trivially happen if someone writes a single 0 byte into a >> PMD area, or of course, when data ends up being zero later. >> >> So let's remove that early exit. >> >> Do we want to CC stable? Hm, not sure. Probably not urgent. >> >> Note that, as default, the THP shrinker is active >> (/sys/kernel/mm/transparent_hugepage/shrink_underused = 1), and all >> THPs are added to the deferred split lists. However, with the >> max_ptes_none default we would never scan them. We would not do that. If >> that's not desirable, we should just disable the shrinker as default, >> also not adding all THPs to the deferred split lists. >> >> Easy to reproduce: >> >> 1) Allocate some THPs filled with 0s >> >> >> #include >> #include >> #include >> #include >> #include >> >> const size_t size = 1024*1024*1024; >> >> int main(void) >> { >> size_t offs; >> char *area; >> >> area = mmap(0, size, PROT_READ | PROT_WRITE, >> MAP_ANON | MAP_PRIVATE, -1, 0); >> if (area == MAP_FAILED) { >> printf("mmap failed\n"); >> exit(-1); >> } >> madvise(area, size, MADV_HUGEPAGE); >> >> for (offs = 0; offs < size; offs += getpagesize()) >> area[offs] = 0; >> pause(); >> } >> <\prog.c> >> >> 2) Trigger the shrinker >> >> E.g., memory pressure through memhog >> >> 3) Observe that THPs are not getting reclaimed >> >> $ cat /proc/`pgrep prog`/smaps_rollup >> >> Would list ~1GiB of AnonHugePages. With this fix, they would get >> reclaimed as expected. >> >> Fixes: dafff3f4c850 ("mm: split underused THPs") >> Cc: Andrew Morton >> Cc: Lorenzo Stoakes >> Cc: Zi Yan >> Cc: Baolin Wang >> Cc: "Liam R. Howlett" >> Cc: Nico Pache >> Cc: Ryan Roberts >> Cc: Dev Jain >> Cc: Barry Song >> Cc: Usama Arif >> Signed-off-by: David Hildenbrand >> --- >> mm/huge_memory.c | 3 --- >> 1 file changed, 3 deletions(-) >> > LGTM. Acked-by: Zi Yan > > I also notice that thp_underused() checks num_zero_pages directly > against khugepaged_max_ptes_none. This means mTHPs will never be regarded > as underused. A similar issue you are discussing in Nico’s khugepaged > mTHP support. Maybe checks against these khugepaged_max* variables > should be calculated based on nr_pages of a large folio, like > making these variables a ratio in other discussion. Yeah, factoring that out and cleaning it up is my next step. But note that mTHPs are not a candidate for the shrinker right now. (see my explanation in reply to Nicos patch) -- Cheers David / dhildenb