From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ua1-f100.google.com (mail-ua1-f100.google.com [209.85.222.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 75E0A3E3D9D for ; Mon, 4 May 2026 16:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.100 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777913900; cv=none; b=mcEqV4TX1+3PW/x3iR05HXbwUIyFVoKgC1pL5AZ5cBb75a8E9EnsrDMLgwgjkYvdyIShzhoKC3DvRz78f4O47KOZ0NNICNh51iRaFr261XR216T+UBXfk127qtbJPzZw6wyAi6Fc7B1/6wjOAZPo6AdOx6Rv96aSgBxUWMF84qQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777913900; c=relaxed/simple; bh=WpgoaaNzosd0BxLmR2WF6+J9dkKSsdxwMIC09WBTJyM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t5MNWo258YSr5hrKJBtr2IbyRdI6XSuTpvrjfsIcKvOBKT/AdIm3Bd4IFLSxJO7DkE1zhbO6gZdZTox2Fb8DGXxKau8SdsghLofiSF+VP07AJWFnuC657hD/0QLkZEfwl9vz0L/wSiV67cgj7Ak1cEH0X7aTPKW2O8siSATcOdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=f6YLROaI; arc=none smtp.client-ip=209.85.222.100 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="f6YLROaI" Received: by mail-ua1-f100.google.com with SMTP id a1e0cc1a2514c-956948531a1so1103393241.2 for ; Mon, 04 May 2026 09:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777913897; x=1778518697; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=faOI5W+NOaiamFpm7prjE2bXLwM58plu3qwpg+EeMUk=; b=QOSTSIOQn5LWKyFzN/ASoNtw3cuFR68wWqQtXtbPRIahejQW6w3ak38LJGRjH8Tz+T e+IAhNfVJsycjEYUsSzb/onkAaFgvx7F6GDqxKor7x/pWHaG4Cf3x6vQMM4gDqDuGL7Q 6CO9VLK0mkAUr5hYp1UouPNDgY3Re/oD7Phs7e0lV3vvyacFId+3zEPl74naoN8xTZnT Mp68JVEdW01Z0exBa2q1UfRquyEjt1Q/V2w6uFVPByWksh722GC+pTE9WfWbl/Qe7xjn GBWpWhgmIu+TXsn7K9cU8x8s/1Vylt0sL+z1WLV9CBc+gK7XG4YtIZz53M2uO3ISWOmE MuqQ== X-Forwarded-Encrypted: i=1; AFNElJ93nBjFpXQXPIXLVAhST8vp8hdzuwchoFNzYwrpKBbMFZZMZ8FykfLXgcDri4dsKpg7RiWtdUo/X6d4OGU=@vger.kernel.org X-Gm-Message-State: AOJu0YzbZeCQjyXs1HiM/wXizTcwHUMc71HUKD8/+gn5o+Cy07eb+1NM 7h0ZggSlw14AcxFw5EGA3ybTV+oJ+3JqkrnyGLjhsu3++hMU4KYDx0HDjfNXBybq4GFipcBuHl2 SU8uLS+adWUxKWSdR5pvCOm/1A57EUwOEqUIHG0fT2/dx1LiU9Nu6tawgT2AYWkOl0m2qHmLQ1E nO35bJ3OYJUhgbvqUZ4tc/q1mSHYKIAaxQ0gWpgVyPJvZpbtBRqhlGundeHMDOkls/MFIccu3ns iCTtevJXu4AOoOE7+YKhuwM X-Gm-Gg: AeBDieu7vlvxfnPh2UxVJ9qd2j45XfPOvR1LsVaN2dyMFB1r6x9lTbDcVjB3ju+M9lK I8W65gfFkwK4oMVqhoxG5hQRcuARUas5yVsRrljY18RR4G3PkU4v7B+LGygnMFYfwVqyeIuLBQo AsMsx3zJoEYrIQj0a/pLMdSwLvWyFaHpbiY0lRLktPbxJTN3unXFhdo+bvYbgI8oO69L8QxYULW SaIV0xso1JGF6JTnIqVyEM2nXFLJ+52ZsJbND01icZep892gHoHtpeZS2wbV17cy3BBSeMMjD/9 oqrI53l8GELmXLBBuhx6B5OxuNZAHnpA6XTEv/2Z/ur7LRiykbNt2jRriDelLP7uRThxMz9k42Z /Ps3juZ7Fp7+ljZkjqDLiZCqG5k10XPi41aYygyBlN/7b6S3wVh2VStvQbPjy+P6hmh6V88WEVu +fmDDTgGUA8fZzy1WTkVA5 X-Received: by 2002:a05:6102:6cb:b0:607:9d3e:2662 with SMTP id ada2fe7eead31-62d84a75024mr4661623137.4.1777913897131; Mon, 04 May 2026 09:58:17 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com ([144.49.247.127]) by smtp-relay.gmail.com with ESMTPS id ada2fe7eead31-62bf8fc3af3sm851742137.0.2026.05.04.09.58.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 May 2026 09:58:17 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-2ee5b73c5f2so5515064eec.0 for ; Mon, 04 May 2026 09:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1777913896; x=1778518696; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=faOI5W+NOaiamFpm7prjE2bXLwM58plu3qwpg+EeMUk=; b=f6YLROaI+OxPSCYN2//MjuwxtPKhOkP7mtdcQRhCPT4FeYnMBhiPzLO6MuMBZCB+8n ZUHaMDXFAZe4SEBOqbVDZUaM44vLShT5irYmc8KLfOxh6fZQE82dl/3TJC6OpsVTxbHy VwDtacTOKpfoKs6pRzz4ZmdDf6s91ncPv4A/s= X-Forwarded-Encrypted: i=1; AFNElJ94ou/LzO5vcJl3e4k0xf+I9Nn85tytO4gjN7uMehR/OlCvahvrAIWrTq1IPsgW1ZQUsrZER3PY1PdYVto=@vger.kernel.org X-Received: by 2002:a05:7300:8c28:b0:2ed:e15:c923 with SMTP id 5a478bee46e88-2efbb7718e3mr4770363eec.31.1777913895990; Mon, 04 May 2026 09:58:15 -0700 (PDT) X-Received: by 2002:a05:7300:8c28:b0:2ed:e15:c923 with SMTP id 5a478bee46e88-2efbb7718e3mr4770325eec.31.1777913895339; Mon, 04 May 2026 09:58:15 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f194556795sm6594936eec.2.2026.05.04.09.58.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2026 09:58:14 -0700 (PDT) Message-ID: <2f453b89-0ce8-4ef3-ae93-c282a2d08fd7@broadcom.com> Date: Mon, 4 May 2026 09:58:13 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] PCI: brcmstb: Assign pcie->gen from pcie_get_link_speed() To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Dom Cobley , Phil Elwell , Jim Quinlan , Broadcom internal kernel review list , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Bjorn Helgaas , Hans Zhang <18255117159@163.com>, "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list References: <20260502114019.GA551304@bhelgaas> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260502114019.GA551304@bhelgaas> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 5/2/26 04:40, Bjorn Helgaas wrote: > On Fri, May 01, 2026 at 01:24:38PM -0700, Florian Fainelli wrote: >> After commit 03f920936977 ("PCI: controller: Validate max-link-speed"), >> pcie->gen stopped being assigned and as a result the established PCIe >> link would stop supporting Gen3 speeds on 2712 since pcie->gen is used >> to populate LnkCntl2 and LnkCap in brcm_pcie_set_gen(). >> >> Link: https://github.com/raspberrypi/linux/issues/7343 >> Reported-by: Dom Cobley >> Reported-by: Phil Elwell >> Fixes: 03f920936977 ("PCI: controller: Validate max-link-speed") >> Signed-off-by: Florian Fainelli >> --- >> drivers/pci/controller/pcie-brcmstb.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c >> index 714bcab97b60..6138fc4bc064 100644 >> --- a/drivers/pci/controller/pcie-brcmstb.c >> +++ b/drivers/pci/controller/pcie-brcmstb.c >> @@ -2072,8 +2072,7 @@ static int brcm_pcie_probe(struct platform_device *pdev) >> return PTR_ERR(pcie->clk); >> >> ret = of_pci_get_max_link_speed(np); >> - if (pcie_get_link_speed(ret) == PCI_SPEED_UNKNOWN) >> - pcie->gen = 0; >> + pcie->gen = pcie_get_link_speed(ret); > > Take a look at https://sashiko.dev/#/patchset/20260501202438.376033-1-florian.fainelli%40broadcom.com > > The notes at https://github.com/raspberrypi/linux/issues/7343 assumed > PCI_SPEED_UNKNOWN was 0, but in fact it is 0xff, which means you might > want the more defensive patch instead. > > I'll be happy to replace what's on pci/for-linus if so. I am starting to think a revert is the simplest path forward, it's not clear what pcie_get_link_speed() brings to the table honestly. -- Florian