From: Jiri Slaby <jirislaby@kernel.org>
To: Parker Newman <parker@finest.io>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Parker Newman" <pnewman@connecttech.com>
Subject: Re: [PATCH v2 4/4] serial: exar: remove ternaries from cti_get_port_type_xr17c15x_xr17v25x()
Date: Mon, 22 Apr 2024 08:34:45 +0200 [thread overview]
Message-ID: <2f505724-4b2c-48ee-90af-52f5d5fa95d7@kernel.org> (raw)
In-Reply-To: <d672326427b1026c7700303eedef8594f2688def.1713533298.git.pnewman@connecttech.com>
On 19. 04. 24, 16:17, Parker Newman wrote:
> From: Parker Newman <pnewman@connecttech.com>
>
> Remove ternary operators from cti_get_port_type_xr17c15x_xr17v25x() for
> better readability.
>
> Signed-off-by: Parker Newman <pnewman@connecttech.com>
Much better.
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> --- a/drivers/tty/serial/8250/8250_exar.c
> +++ b/drivers/tty/serial/8250/8250_exar.c
> @@ -726,7 +726,7 @@ static enum cti_port_type cti_get_port_type_xr17c15x_xr17v25x(struct exar8250 *p
> struct pci_dev *pcidev,
> unsigned int port_num)
> {
> - enum cti_port_type port_type;
> + enum cti_port_type port_type = CTI_PORT_TYPE_RS232;
>
> switch (pcidev->subsystem_device) {
> // RS232 only cards
Unrelated to this one, but // comments are discouraged in the kernel, IMO?
thanks,
--
js
suse labs
next prev parent reply other threads:[~2024-04-22 6:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 14:17 [PATCH v2 0/4] serial: exar: fix kbuild warnings and code style Parker Newman
2024-04-19 14:17 ` [PATCH v2 1/4] serial: exar: add missing kernel doc function parameters Parker Newman
2024-04-19 14:17 ` [PATCH v2 2/4] serial: exar: use return dev_err_probe instead of returning error code Parker Newman
2024-04-19 14:17 ` [PATCH v2 3/4] serial: exar: return bool from exar_ee_read_bit() Parker Newman
2024-04-19 14:17 ` [PATCH v2 4/4] serial: exar: remove ternaries from cti_get_port_type_xr17c15x_xr17v25x() Parker Newman
2024-04-22 6:34 ` Jiri Slaby [this message]
2024-05-02 16:18 ` [PATCH v2 0/4] serial: exar: fix kbuild warnings and code style Parker Newman
2024-05-04 16:01 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f505724-4b2c-48ee-90af-52f5d5fa95d7@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=parker@finest.io \
--cc=pnewman@connecttech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox