From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB257C433EF for ; Tue, 15 Feb 2022 18:43:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243178AbiBOSoD (ORCPT ); Tue, 15 Feb 2022 13:44:03 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:50244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241980AbiBOSoA (ORCPT ); Tue, 15 Feb 2022 13:44:00 -0500 Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E176B27FF6 for ; Tue, 15 Feb 2022 10:43:49 -0800 (PST) Received: by mail-il1-x135.google.com with SMTP id h11so15523473ilq.9 for ; Tue, 15 Feb 2022 10:43:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=A0+kP93DPXHvr6brEvM8VXEFzWB0S5lRFdtA9kDJkyE=; b=VbnG0DTFoD5oInsLnSpyK8TY1b9yTtEV8jmDclcI0lVoHXaRfQ+1Kei06xf8rXYF7T Wg/jkDG2mswlylVxkUyUwagh7VpOigDobBSIN+ruOXrKdEbqescCjLVZjKa5xcviv9J2 6BHdIVuOY/izVwkXKs6tMZ1SXb1wuGFnkP+R4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=A0+kP93DPXHvr6brEvM8VXEFzWB0S5lRFdtA9kDJkyE=; b=QpE2M4zPcDWkK7tRYsMbd/I2REEkYC87riK+uxfAF66mWn4kDUQgaLN7Z1UvfVsQht HjTzqpBxCTNlBjF9SpB6O11FH8ifGNpvL90nhLQYFV9BqeABD7tEvO1nNXpUme/wA7cn +HX28iw/mXDxSo/5WmY/oIAiUopWCBhODa2b3tKhQC6h5opfs40Cdp4ED97Yipyq9E3n OHDE3wHxP4Vt8zFD3vNLHfConQmHOjD67Vl+lhyeOjSLYAG7540VK8PgBCvKJC+Nufob rZqnnjOsEcVX57ZEG71trMiQsBOOnJivqpMnNDVmKdNqYC5G5vyHLqpp958OQ2EMItrD To+w== X-Gm-Message-State: AOAM530v66vDbVaHIsQVYASod3ucRqPQLPAuEjsXz4FzvlWctfLy6wXu f65ovjcJslCoSQWOyP4c+2rmCQ== X-Google-Smtp-Source: ABdhPJy2vlGZWPGrF4v8TITllv20RRsSaBCpm9YRhgNODL/5uMIm2Jii7qjTHVGojYsoa6gztygi5g== X-Received: by 2002:a05:6e02:1bc1:: with SMTP id x1mr258711ilv.268.1644950629300; Tue, 15 Feb 2022 10:43:49 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id s16sm12850411iow.10.2022.02.15.10.43.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 10:43:49 -0800 (PST) Subject: Re: [PATCH v2] selftests/seccomp: Fix seccomp failure by adding missing headers To: Muhammad Usama Anjum , Sherry Yang Cc: "shuah@kernel.org" , Kees Cook , "luto@amacapital.net" , "wad@chromium.org" , "christian@brauner.io" , "ast@kernel.org" , "daniel@iogearbox.net" , "andrii@kernel.org" , "kafai@fb.com" , "songliubraving@fb.com" , "yhs@fb.com" , "john.fastabend@gmail.com" , "kpsingh@kernel.org" , "linux-kselftest@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , "bpf@vger.kernel.org" , Shuah Khan References: <20220210203049.67249-1-sherry.yang@oracle.com> <755ec9b2-8781-a75a-4fd0-39fb518fc484@collabora.com> <85DF69B3-3932-4227-978C-C6DAC7CAE64D@oracle.com> <66140ffb-306e-2956-2f6b-c017a38e18f8@collabora.com> <4b739847-0622-c221-33b3-9fe428a52bc0@collabora.com> From: Shuah Khan Message-ID: <2f59f86c-dbd7-7dbf-021d-bc62ebbe2a43@linuxfoundation.org> Date: Tue, 15 Feb 2022 11:43:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <4b739847-0622-c221-33b3-9fe428a52bc0@collabora.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/15/22 11:17 AM, Muhammad Usama Anjum wrote: > > On 2/14/22 9:12 PM, Muhammad Usama Anjum wrote: >>>> "../../../../usr/include/" directory doesn't have header files if >>>> different output directory is used for kselftests build like "make -C >>>> tools/tests/selftest O=build". Can you try adding recently added >>>> variable, KHDR_INCLUDES here which makes this kind of headers inclusion >>>> easy and correct for other build combinations as well? >>>> >>>> >>> >>> Hi Muhammad, >>> >>> I just pulled linux-next, and tried with KHDR_INCLUDES. It works. Very nice >>> work! I really appreciate you made headers inclusion compatible. However, >>> my case is a little more complicated. It will throw warnings with -I, using >>> -isystem can suppress these warnings, more details please refer to >>> https://lore.kernel.org/all/C340461A-6FD2-440A-8EFC-D7E85BF48DB5@oracle.com/ >>> >>> According to this case, do you think will it be better to export header path >>> (KHDR_INCLUDES) without “-I”? >> Well said. I've thought about it and it seems like -isystem is better >> than -I. I've sent a patch: >> https://lore.kernel.org/linux-kselftest/20220214160756.3543590-1-usama.anjum@collabora.com/ >> I'm looking forward to discussion on it. > The patch has been accepted. It should appear in linux-next soon. You > should be able to use KHDR_INCLUDES easily now. > Sherry, I pulled in your patch as a fix as is for 5.17-rc5. Using KHDR_INCLUDES can be separate patch for next release. This way the fix is going to be pulled for this release without dependencies on other patches. thanks, -- Shuah