From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-fpga@vger.kernel.org, Xu Yilun <yilun.xu@intel.com>,
Wu Hao <hao.wu@intel.com>, Tom Rix <trix@redhat.com>,
Moritz Fischer <mdf@kernel.org>, Lee Jones <lee@kernel.org>,
Matthew Gerlach <matthew.gerlach@linux.intel.com>,
Russ Weight <russell.h.weight@intel.com>,
Tianfei zhang <tianfei.zhang@intel.com>,
Mark Brown <broonie@kernel.org>,
Marco Pagani <marpagan@redhat.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 9/9] mfd: intel-m10-bmc: Change MODULE_LICENSE() to GPL
Date: Mon, 5 Dec 2022 11:05:44 +0200 (EET) [thread overview]
Message-ID: <2f692caa-bbf3-b5c6-ce11-af8148f1293c@linux.intel.com> (raw)
In-Reply-To: <Y4xr+nmx7m66+KsL@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1359 bytes --]
On Sun, 4 Dec 2022, Greg KH wrote:
> On Fri, Dec 02, 2022 at 12:08:41PM +0200, Ilpo Järvinen wrote:
> > "GPL v2" should not be used as MODULE_LICENSE(). "GPL" is enough, see
> > commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL
> > v2" bogosity") for more details.
>
> And that commit says that leaving "GPL v2" is just fine and dandy and
> should not be an issue at all.
From reading just it's changelog, it's hard to come into that conclusion
(in fact, the opposite reading is very much crafted into many of the
wordings in the changelog, e.g., stating that "GPL" is "completely
sufficient" and that other ways assume wrongly distinction, etc.).
Only after reading now the diff itself, I can see that being the case.
> Please do not change the license for no good reason. That commit is NOT
> a good reason to change it at all.
>
> so NAK on this patch, sorry.
Okay, I'm certainly fine dropping it :-).
The reason why I added this change was checkpatch giving this:
WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module:
Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
...And bf7fbeeae6db's changelog then further reinforced that "GPL" is
sufficient.
I guess checkpatch wanted to give the warning only for new stuff but
since I was moving code around it misdetected the moved bits as new.
--
i.
prev parent reply other threads:[~2022-12-05 9:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-02 10:08 [PATCH v3 0/9] intel-m10-bmc: Split BMC to core and SPI parts & add PMCI+N6000 support Ilpo Järvinen
2022-12-02 10:08 ` [PATCH v3 1/9] mfd: intel-m10-bmc: Create m10bmc_platform_info for type specific info Ilpo Järvinen
2022-12-02 10:08 ` [PATCH v3 2/9] mfd: intel-m10-bmc: Rename the local variables Ilpo Järvinen
2022-12-02 10:08 ` [PATCH v3 3/9] mfd: intel-m10-bmc: Split into core and spi specific parts Ilpo Järvinen
2022-12-02 10:08 ` [PATCH v3 4/9] mfd: intel-m10-bmc: Support multiple CSR register layouts Ilpo Järvinen
2022-12-02 10:08 ` [PATCH v3 5/9] fpga: intel-m10-bmc: Rework flash read/write Ilpo Järvinen
2022-12-02 10:08 ` [PATCH v3 6/9] mfd: intel-m10-bmc: Downscope SPI defines & prefix with M10BMC_SPI Ilpo Järvinen
2022-12-02 16:28 ` Xu Yilun
2022-12-02 17:29 ` Russ Weight
2022-12-05 9:31 ` Ilpo Järvinen
2022-12-05 15:41 ` Xu Yilun
2022-12-08 11:57 ` Ilpo Järvinen
2022-12-02 10:08 ` [PATCH v3 7/9] mfd: intel-m10-bmc: Add PMCI driver Ilpo Järvinen
2022-12-02 17:12 ` Xu Yilun
2022-12-05 9:51 ` Ilpo Järvinen
2022-12-05 12:05 ` Mark Brown
2022-12-05 15:08 ` Xu Yilun
2022-12-05 18:22 ` Mark Brown
2022-12-06 2:37 ` Xu Yilun
2022-12-05 16:28 ` Xu Yilun
2022-12-02 10:08 ` [PATCH v3 8/9] fpga: m10bmc-sec: Add support for N6000 Ilpo Järvinen
2022-12-02 10:08 ` [PATCH v3 9/9] mfd: intel-m10-bmc: Change MODULE_LICENSE() to GPL Ilpo Järvinen
2022-12-04 9:44 ` Greg KH
2022-12-05 9:05 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f692caa-bbf3-b5c6-ce11-af8148f1293c@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hao.wu@intel.com \
--cc=lee@kernel.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marpagan@redhat.com \
--cc=matthew.gerlach@linux.intel.com \
--cc=mdf@kernel.org \
--cc=russell.h.weight@intel.com \
--cc=tianfei.zhang@intel.com \
--cc=trix@redhat.com \
--cc=yilun.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox