Re: [PATCH] tty: pty: remove redundant initialization of variable fd

[Jiri Slaby <jirislaby@kernel.org>]

On 14. 05. 21, 0:18, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> The variable fd is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
> 
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> ---
>   drivers/tty/pty.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
> index 9b5d4ae5d8f2..2251330e7e00 100644
> --- a/drivers/tty/pty.c
> +++ b/drivers/tty/pty.c
> @@ -626,7 +626,7 @@ static struct cdev ptmx_cdev;
>    */
>   int ptm_open_peer(struct file *master, struct tty_struct *tty, int flags)
>   {
> -	int fd = -1;
> +	int fd;
>   	struct file *filp;
>   	int retval = -EINVAL;
>   	struct path path;
> 


-- 
js
suse labs