* [PATCH 1/1] Fixed checkpatch error to mmu.c
@ 2016-12-12 10:46 Ozgur Karatas
2016-12-12 11:02 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: Ozgur Karatas @ 2016-12-12 10:46 UTC (permalink / raw)
To: christoffer.dall, marc.zyngier, pbonzini
Cc: linux-arm-kernel, kvm, linux-kernel
Hello all,
I tested to mmu.c and I have fixed to some errors.
mmu.c:510: ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Ozgur Karatas <okaratas@member.fsf.org>
---
arch/arm/kvm/mmu.c | 2 +-
diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
index a5265ed..a83cf47 100644
--- a/arch/arm/kvm/mmu.c
+++ b/arch/arm/kvm/mmu.c
@@ -507,7 +507,7 @@ void free_hyp_pgds(void)
unmap_hyp_range(hyp_pgd, hyp_idmap_start, PAGE_SIZE);
for (addr = PAGE_OFFSET; virt_addr_valid(addr); addr += PGDIR_SIZE)
unmap_hyp_range(hyp_pgd, kern_hyp_va(addr), PGDIR_SIZE);
- for (addr = VMALLOC_START; is_vmalloc_addr((void*)addr); addr += PGDIR_SIZE)
+ for (addr = VMALLOC_START; is_vmalloc_addr((void *)addr); addr += PGDIR_SIZE)
unmap_hyp_range(hyp_pgd, kern_hyp_va(addr), PGDIR_SIZE);
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] Fixed checkpatch error to mmu.c
2016-12-12 10:46 [PATCH 1/1] Fixed checkpatch error to mmu.c Ozgur Karatas
@ 2016-12-12 11:02 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2016-12-12 11:02 UTC (permalink / raw)
To: Ozgur Karatas, christoffer.dall, pbonzini
Cc: linux-arm-kernel, kvm, linux-kernel
Hi Ozgur,
On 12/12/16 10:46, Ozgur Karatas wrote:
> Hello all,
>
> I tested to mmu.c and I have fixed to some errors.
>
> mmu.c:510: ERROR: "(foo*)" should be "(foo *)"
>
> Signed-off-by: Ozgur Karatas <okaratas@member.fsf.org>
> ---
> arch/arm/kvm/mmu.c | 2 +-
>
> diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
> index a5265ed..a83cf47 100644
> --- a/arch/arm/kvm/mmu.c
> +++ b/arch/arm/kvm/mmu.c
> @@ -507,7 +507,7 @@ void free_hyp_pgds(void)
> unmap_hyp_range(hyp_pgd, hyp_idmap_start, PAGE_SIZE);
> for (addr = PAGE_OFFSET; virt_addr_valid(addr); addr += PGDIR_SIZE)
> unmap_hyp_range(hyp_pgd, kern_hyp_va(addr), PGDIR_SIZE);
> - for (addr = VMALLOC_START; is_vmalloc_addr((void*)addr); addr += PGDIR_SIZE)
> + for (addr = VMALLOC_START; is_vmalloc_addr((void *)addr); addr += PGDIR_SIZE)
> unmap_hyp_range(hyp_pgd, kern_hyp_va(addr), PGDIR_SIZE);
>
I'm not overly sympathetic to pure checkpatch patches. If you find
something that is a functional bug in that file, I'll consider it as
part of a series. But on its own, this is just noise.
Thanks,
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-12 11:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-12 10:46 [PATCH 1/1] Fixed checkpatch error to mmu.c Ozgur Karatas
2016-12-12 11:02 ` Marc Zyngier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox