From: David Laight <David.Laight@ACULAB.COM>
To: 'Arseniy Krasnov' <AVKrasnov@sberdevices.ru>,
Liang Yang <liang.yang@amlogic.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
"Richard Weinberger" <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Yixun Lan <yixun.lan@amlogic.com>,
Jianxin Pan <jianxin.pan@amlogic.com>
Cc: "oxffffaa@gmail.com" <oxffffaa@gmail.com>,
"kernel@sberdevices.ru" <kernel@sberdevices.ru>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-amlogic@lists.infradead.org"
<linux-amlogic@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define
Date: Wed, 12 Apr 2023 10:06:39 +0000 [thread overview]
Message-ID: <2f89000bdbbb4e2bb7f1dd96c1b498f9@AcuMS.aculab.com> (raw)
In-Reply-To: <20230412061700.1492474-3-AVKrasnov@sberdevices.ru>
From: Arseniy Krasnov
> Sent: 12 April 2023 07:17
> Subject: [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define
>
...
> len = mtd->writesize + mtd->oobsize;
> - cmd = (len & GENMASK(13, 0)) | scrambler | DMA_DIR(dir);
> + cmd = (len & NFC_CMD_RAW_LEN) | scrambler | DMA_DIR(dir);
> writel(cmd, nfc->reg_base + NFC_REG_CMD);
What is the point of the mask?
If the length is too big it just generates a different
'hard to debug' error.
If the length can't be too bit there is no point masking it.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-04-12 10:07 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 6:16 [PATCH v1 0/5] refactoring and fix for Meson NAND Arseniy Krasnov
2023-04-12 6:16 ` [PATCH v1 1/5] mtd: rawnand: meson: fix NAND access for read/write Arseniy Krasnov
2023-04-12 9:37 ` Liang Yang
2023-04-12 10:24 ` Arseniy Krasnov
2023-04-12 12:03 ` Arseniy Krasnov
2023-04-12 13:30 ` Liang Yang
2023-04-13 5:10 ` Arseniy Krasnov
2023-04-13 5:57 ` Liang Yang
2023-04-17 6:47 ` Arseniy Krasnov
2023-04-17 13:54 ` Liang Yang
2023-04-17 14:10 ` Arseniy Krasnov
2023-04-19 19:43 ` Arseniy Krasnov
2023-04-20 14:22 ` Liang Yang
2023-04-21 5:57 ` Arseniy Krasnov
2023-04-26 7:53 ` Arseniy Krasnov
2023-04-26 12:17 ` Liang Yang
2023-04-12 6:16 ` [PATCH v1 2/5] mtd: rawnand: meson: replace GENMASK() macro with define Arseniy Krasnov
2023-04-12 7:37 ` Neil Armstrong
2023-04-12 10:06 ` David Laight [this message]
2023-04-12 10:11 ` Arseniy Krasnov
2023-04-12 6:16 ` [PATCH v1 3/5] mtd: rawnand: meson: check buffer length Arseniy Krasnov
2023-04-12 7:39 ` Miquel Raynal
2023-04-12 6:16 ` [PATCH v1 4/5] mtd: rawnand: meson: clear OOB buffer before read Arseniy Krasnov
2023-04-12 7:44 ` Miquel Raynal
2023-04-12 7:47 ` Miquel Raynal
2023-04-12 9:20 ` Arseniy Krasnov
2023-04-12 9:36 ` Miquel Raynal
2023-04-12 10:14 ` Arseniy Krasnov
2023-04-12 10:51 ` Liang Yang
2023-04-12 11:36 ` Liang Yang
2023-04-12 11:43 ` Dmitry Rokosov
2023-04-12 11:47 ` Arseniy Krasnov
2023-04-12 12:28 ` Liang Yang
2023-04-12 12:18 ` Miquel Raynal
2023-04-12 12:22 ` Arseniy Krasnov
2023-04-12 12:57 ` Miquel Raynal
2023-04-12 14:04 ` Liang Yang
2023-04-12 14:32 ` Miquel Raynal
2023-04-13 5:32 ` Liang Yang
2023-04-13 6:11 ` Liang Yang
[not found] ` <7520e512-8a19-ff04-364c-b5be0a579ef0@sberdevices.ru>
2023-04-13 8:22 ` Miquel Raynal
[not found] ` <b3279de4-e89d-db03-a515-a6aa52ab90d3@sberdevices.ru>
2023-04-13 10:22 ` Miquel Raynal
[not found] ` <569a948e-654a-b21f-8a4f-55dc4b295387@sberdevices.ru>
[not found] ` <60fa656e-bda1-1de6-a79e-3e3041cd69a8@sberdevices.ru>
2023-04-18 12:24 ` Liang Yang
[not found] ` <e7c49f2d-b3c1-8d9b-76fe-c8759b37c7c7@sberdevices.ru>
2023-04-18 13:25 ` Miquel Raynal
[not found] ` <15a6e415-1489-a81f-fc8f-2372678ad2cb@sberdevices.ru>
2023-04-19 3:05 ` Liang Yang
[not found] ` <5e4b395e-bf9d-0123-a0f2-2b378d950b29@sberdevices.ru>
[not found] ` <fda1ae91-4bf8-6945-bd0d-b6dabc9cb4bd@sberdevices.ru>
2023-04-26 13:51 ` Liang Yang
[not found] ` <cf27b6b4-a75b-c5a6-32ea-ac20a2984192@sberdevices.ru>
2023-05-02 9:59 ` Miquel Raynal
[not found] ` <2274b432-d1a9-b3cf-4f7b-08c4a4c580b5@sberdevices.ru>
2023-05-02 11:27 ` Miquel Raynal
[not found] ` <2b2f5cb4-84f7-65f6-13b2-42f965503023@sberdevices.ru>
2023-05-02 12:17 ` Miquel Raynal
[not found] ` <91cb8e19-e782-b847-8d2b-22580c371c34@sberdevices.ru>
2023-05-02 13:05 ` Miquel Raynal
[not found] ` <8996d53c-54ff-6a37-e08b-95cae0629703@sberdevices.ru>
2023-05-03 8:03 ` Miquel Raynal
2023-05-03 19:48 ` Richard Weinberger
[not found] ` <c160eb18-fa50-88a9-a4cf-4afb1b46b177@sberdevices.ru>
[not found] ` <805dea68-8a40-a52a-ad7c-b2e9cd3d05a8@sberdevices.ru>
2023-05-04 12:17 ` Miquel Raynal
2023-04-13 8:22 ` Miquel Raynal
2023-04-12 19:15 ` Dmitry Rokosov
2023-04-12 20:56 ` Miquel Raynal
2023-04-13 9:27 ` Dmitry Rokosov
2023-04-13 10:29 ` Miquel Raynal
2023-04-13 14:03 ` Dmitry Rokosov
2023-04-12 6:16 ` [PATCH v1 5/5] mtd: rawnand: meson: remove unneeded bitwise OR with zeroes Arseniy Krasnov
2023-04-12 7:45 ` [PATCH v1 0/5] refactoring and fix for Meson NAND Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f89000bdbbb4e2bb7f1dd96c1b498f9@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=AVKrasnov@sberdevices.ru \
--cc=jbrunet@baylibre.com \
--cc=jianxin.pan@amlogic.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=liang.yang@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=miquel.raynal@bootlin.com \
--cc=neil.armstrong@linaro.org \
--cc=oxffffaa@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yixun.lan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox