From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 60BF12E0920 for ; Mon, 15 Dec 2025 13:30:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765805405; cv=none; b=dhvm7ZH6MFS4Cet9hpiXOtrCsDFaRJ6B7oqQKCyIdX6VQdAulGexvw8icd/g8jDuugiVaHEd7lLhvhweVsuUFrIF/+E8sChvBsNU8ZXkzLlSPdOt489YsnaUMGvugWtQqEQ/j1Rkw9UMTKE+0O25Xi2d1LTzxmCE2TjHKnnwoDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765805405; c=relaxed/simple; bh=yilNrHpHZPkvhLfgZc7bdKvRXmDizdXeRgViDGXAlME=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uUIbvlG94alVickujwKVoNkiXtGdA7ktHBZxeW/5zx52rcbTzZuaFP/2Swb/WaKT1pUlfukeI8gmZGSjPr9SXffFMQGopXQ/M+V2MqtJk+y/5TEfGonHzAZ5KL4b9LoZghbyW0FrA8K8yaAKdXPoqNNbAukriMb0sSTWf4Nk1wI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LN2/+CzD; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LN2/+CzD" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2a0b4320665so20107955ad.1 for ; Mon, 15 Dec 2025 05:30:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765805404; x=1766410204; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d+11n5xHa65Fb5deTVwy48x8a95WBa5RIlNHjK4BN00=; b=LN2/+CzDUBvuDz+baelHh93piEe4PcfZU9D541A9pWLEWbQJsF/gvvKG+iQN4KeHin XX5dtTCiUhjdxyeCONs0+Yl+1IaSyX1UX444u08i+VMehygMaMGEWHuf6QHkCpU5Lgrw Fw3xwl6uXlZ0JW3+/dFR3eH2/L1XPNzU+jFb5Nbm5kYNN4h+HmJh8s+T9ubhReazrAZ/ NNXagcODUzsq0xYA0fLXfnV3M3MPb7WnYMM8G1/5MQVrVw7akl7RA9A7u1ThyIEOhRaP iGGgyTKk+CjO8uD2x4Q74ybMG+sRoaCRMcYlwRUjG9RGf5Y4rVGTd/NXVr5faf2uYtS9 S5MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765805404; x=1766410204; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d+11n5xHa65Fb5deTVwy48x8a95WBa5RIlNHjK4BN00=; b=u5UrPeWlWDmibcjXpj28zVi9BgujPIKZL7vz0rRqKePRCbQ/UFICSNK9YW0AA5m+F5 gmdT+GTrjKbbOrm7f2/QUH+qacCSGUMhiREjsM6+hiY4QzjFxtI72ixmjAoHudCBgz5W o9w4VDoEr5+AFgbWpPcXi+nqViRiJkZgbPABmMvq2IVkGvxU6VU4+zFVWkPrNBT355W7 qMpcg7mJ9xJFqsaU/aOagu0qT4dDc6NDl4EFX8/1Es7Wqul9S1ebiqW/jzQpVARdyUhu U0McsdSCPPh6awXQEdpk3r8St7QW2ZHwqj54ivPMKp6LfjDLioS7Z+WYXtE8E95XXrAm UNeA== X-Forwarded-Encrypted: i=1; AJvYcCXk/bd+1TKoiUgbzo8GyRTRmoOHcECiuSNqDomhl2i+6VbvBVQD+himzQ8EU++DyWkLGa6mQU9xrX9NTPE=@vger.kernel.org X-Gm-Message-State: AOJu0YzSTB5CuCBrOjC3t1JovzjtuYiEoY4ZLMbj6hFWqWUV0yaELCTd V6mXJDX4ovmvQQMIofDVyj7oZY1hDFQWBFLeEq5dELUkgic96wGsLznA X-Gm-Gg: AY/fxX4sJqkEdw+rx/C6xk4MtKu0jJEn23e3PlxWuNtoUaNvE4g2bDxB6T+IKrfmX1I NiH09HzIG2nOb7cBN3YaGraB5mhpaJdh56SshvqXPMu+7aQmjSc02dHWEtE+gbKY8gNV1B5kZS3 Wh9loASBeXZixIlG6c5NaKqOUZ1famXRchkcI3SowL75rB8VLZ1h+KQCPOMJU/yZ5fXmxF0b6vq gFZLCJGVI9jv0rahoFWV6xegwO651mjds8NL0mgpDemV8tIdj6MQpDGZjnVdWPSfDI976Zu62N+ sO1BEG3w3sdK130GUg2cKtflwGssruezBWBqoVNGYTfI5y5jUopGReuJTRyuoQVnMpc2qjNin2c MxTFIrR7Wvm50KszahJQ+fVUfIhPZh1C0sQ5GxbSksYTwolwnZrwIIl5YOq5W4xs1Y0GRmsZosM +XPmbtvNcN4vuupUZ0iABwR8iZmY+kqNNcwzU= X-Google-Smtp-Source: AGHT+IEtCn7RCKYrfOQv0VLR0gIK+RnVSUAv5QdRQXlQ50oZhdE1Y/XjPK/4zORkdAPHbPP0TygwwA== X-Received: by 2002:a17:903:120e:b0:296:4d61:6cdb with SMTP id d9443c01a7336-29f23b77debmr115041045ad.27.1765805403657; Mon, 15 Dec 2025 05:30:03 -0800 (PST) Received: from [172.16.20.12] ([136.226.244.245]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29eea016e21sm136133595ad.55.2025.12.15.05.30.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 05:30:03 -0800 (PST) Message-ID: <2fa1ed49-4051-4ecc-a38c-de2c7b97dc03@gmail.com> Date: Mon, 15 Dec 2025 19:00:31 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 2/2] arm64: dts: qcom: talos-evk: Add support for QCS615 talos evk board To: Konrad Dybcio , andersson@kernel.org, konradybcio@kernel.org Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251201172222.3764933-1-tessolveupstream@gmail.com> <20251201172222.3764933-3-tessolveupstream@gmail.com> <846a5cc1-fa0b-4952-ab40-852a07607eb7@oss.qualcomm.com> Content-Language: en-US From: tessolveupstream@gmail.com In-Reply-To: <846a5cc1-fa0b-4952-ab40-852a07607eb7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05-12-2025 16:22, Konrad Dybcio wrote: > On 12/1/25 6:22 PM, Sudarshan Shetty wrote: >> Add the device tree for the QCS615-based Talos EVK platform. The >> platform is composed of a System-on-Module following the SMARC >> standard, and a Carrier Board. > > [...] > >> + hdmi-out { > > You must refer to existing nodes by &label references - let's call > this one hdmi_connector: hdmi-out {} > Okay, will update in v10 patch. > [...] > >> +&i2c1 { >> + clock-frequency = <400000>; >> + >> + status = "okay"; >> + >> + bridge@3d { >> + status = "disabled"; >> + }; > > Similarly here - hdmi_bridge: bridge@3d {} > Okay. >> + >> + bridge: bridge@2c { > > lvds_bridge: > Okay, got it. > [...] > > + >> + sn65dsi84_in: endpoint { >> + data-lanes = <0 1 2 3>; >> + remote-endpoint = <&mdss_dsi0_out>; > > The formatting fell apart a little here - please give it a touch-up > Okay, will update in v10 patch. > [...] > >> +&tlmm { >> + pcie_default_state: pcie-default-state { >> + clkreq-pins { >> + pins = "gpio90"; >> + function = "pcie_clk_req"; >> + drive-strength = <2>; >> + bias-pull-up; >> + }; >> + >> + perst-pins { >> + pins = "gpio101"; >> + function = "gpio"; >> + drive-strength = <2>; >> + bias-pull-down; > > bias-disable - this pin is active-low > Okay, got it. Will update in next patch > [...] > >> +&i2c1 { >> + clock-frequency = <400000>; >> + status = "okay"; >> + bridge: bridge@3d { > > This really needs a \n above Okay. >> + compatible = "adi,adv7535"; >> + reg = <0x3d>; >> + avdd-supply = <&vreg_v1p8_out>; >> + dvdd-supply = <&vreg_v1p8_out>; >> + pvdd-supply = <&vreg_v1p8_out>; >> + a2vdd-supply = <&vreg_v1p8_out>; >> + v3p3-supply = <&vreg_v3p3_out>; >> + interrupts-extended = <&tlmm 26 IRQ_TYPE_LEVEL_LOW>; >> + adi,dsi-lanes = <4>; >> + ports { > > And here Understood, will take care in v10 patch. > > Konrad