From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEEA83DAACF; Fri, 24 Jul 2026 08:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.14 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882176; cv=none; b=oUCZ+3CkJGq1dSrGoUqgPjllzYjYHkxd5XWmAHi6dgcuoWv7vLJOmPWja5OkxzEZI7Bl4YXRf0wtECyCWZzIVuE6hoJB7SVqQMFqyOYcnOgJ91JpGoXEtCGPSXFvJDrvqPOyu3IrM6IZeKR6W06nNieTRuByIYnDBJ2Ylq+9H1w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784882176; c=relaxed/simple; bh=2m27K8YDA2d3oCx+0nulJY0uzC0LDomgZgzJ9anfsnE=; h=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=ksLbnGb+Zsc1OgZnmuGbMrNmgZMNl+eqbuOYQHPohsFYhk9EOp8YCKhcWbK45PguyfQxlhb6ruzhOpKMgaTFI5AJdkXAWjflCs0J0RfqsDIu3Sf4bGqqeb06LC7bIDCe2ntm3ZZDjeaynkUObN6m7OUPD3IMNVnxMbUPhgPrhik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=pass smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=nlnLy6xM; arc=none smtp.client-ip=198.175.65.14 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="nlnLy6xM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784882172; x=1816418172; h=from:date:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=2m27K8YDA2d3oCx+0nulJY0uzC0LDomgZgzJ9anfsnE=; b=nlnLy6xMmZ4YfaBPl9EhEJETR6npgC/lKj2EkolxQpxne5laqV2M6r9x SxNcLpk/0Ft2aoLhkCTv4cppIU+mlgc0Q5sRbhLeM1AooExmiQD0o2VJG bxWV90QFKIsnJMu7fucEYCTp8GbiBpE0/tAdsi68+1cYxio/IO6Nvqjtm 73U7Q8zJ69si7boC2gzmG03N9qaFsrDgJE5O4xKcS0rlwXEqg8bKOIkWi xdMVJUm/qipWF+xaNJxiK8rq+MbsrRZvfzul91Ab/w6BfkHqI/mRcqpil /xjcwuSRQkVa0yTDX39mDVshU8uCMgjymeyYQ+khGX3AxLHF7CZP2Db6s g==; X-CSE-ConnectionGUID: tTH31UUEQaq3vHbg3nAvQA== X-CSE-MsgGUID: ympgh19RQJKUbtXP8T1jRg== X-IronPort-AV: E=McAfee;i="6800,10657,11854"; a="89437725" X-IronPort-AV: E=Sophos;i="6.25,182,1779174000"; d="scan'208";a="89437725" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2026 01:36:05 -0700 X-CSE-ConnectionGUID: PWfznRuFRFSHbos9XEK9iw== X-CSE-MsgGUID: K46nMSzBQGe8BkQ8EFXI2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,182,1779174000"; d="scan'208";a="281959926" Received: from ijarvine-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.8]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2026 01:35:56 -0700 From: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= Date: Fri, 24 Jul 2026 11:35:52 +0300 (EEST) To: Sean Rhodes cc: tzungbi@kernel.org, Hans de Goede , corentin.chary@gmail.com, luke@ljones.dev, denis.benato@linux.dev, prasanth.ksr@dell.com, jorge.lopez2@hp.com, Mark Pearson , derekjohn.clark@gmail.com, josh@joshuagrisham.com, briannorris@chromium.org, jwerner@chromium.org, tzimmermann@suse.de, javierm@redhat.com, kees@kernel.org, u.kleine-koenig@baylibre.com, mst@redhat.com, chenhuacai@kernel.org, wenst@chromium.org, florian.fainelli@broadcom.com, titouan.ameline@gmail.com, oliver@liuxiaozhen.dev, LKML , platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, chrome-platform@lists.linux.dev Subject: Re: [PATCH v8 1/4] platform/x86: Sort firmware attributes class includes In-Reply-To: Message-ID: <2fa8bf8d-162d-db04-a85a-5f591fee447b@linux.intel.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII On Wed, 22 Jul 2026, Sean Rhodes wrote: > Move firmware_attributes_class.h into the main include block and sort the > affected includes. This lets the header move replace each include in place. > > Suggested-by: Derek J. Clark > Signed-off-by: Sean Rhodes > --- > drivers/platform/x86/asus-armoury.c | 2 +- > drivers/platform/x86/dell/dell-wmi-sysman/sysman.c | 9 +++++---- > drivers/platform/x86/hp/hp-bioscfg/bioscfg.c | 9 +++++---- > drivers/platform/x86/lenovo/think-lmi.c | 5 +++-- > drivers/platform/x86/lenovo/wmi-other.c | 2 +- > drivers/platform/x86/samsung-galaxybook.c | 3 ++- > 6 files changed, 17 insertions(+), 13 deletions(-) > > diff --git a/drivers/platform/x86/asus-armoury.c > b/drivers/platform/x86/asus-armoury.c > index 495dc1e31d40..f3d8c5a85762 100644 > --- a/drivers/platform/x86/asus-armoury.c > +++ b/drivers/platform/x86/asus-armoury.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include "firmware_attributes_class.h" > #include > #include > #include > @@ -34,7 +35,6 @@ > #include > > #include "asus-armoury.h" > -#include "firmware_attributes_class.h" > > #define ASUS_NB_WMI_EVENT_GUID "0B3CBB35-E3C2-45ED-91C2-4C5A6D195D1C" > > diff --git a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c > b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c > index ab46a023cc34..4ff9003c6589 100644 > --- a/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c > +++ b/drivers/platform/x86/dell/dell-wmi-sysman/sysman.c > @@ -8,18 +8,19 @@ > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > #include > -#include > #include > -#include > +#include "../../firmware_attributes_class.h" > +#include > #include > +#include > +#include > #include > #include > #include > + > #include "dell-wmi-sysman.h" > -#include "../../firmware_attributes_class.h" I'm sorry I probably wasn't specific enough with my comment but the custom is to have the local includes separately in own block of includes (empty line in between). Also, if there's a case where there is's linux/xx.h and someotherfolder/xx.h, those should be in own "blocks" of include, each group sorted alphabetically. -- i. > #define MAX_TYPES 4 > -#include > > struct wmi_sysman_priv wmi_priv = { > .mutex = __MUTEX_INITIALIZER(wmi_priv.mutex), > diff --git a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c > b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c > index 27fd6cd21529..1965a329be48 100644 > --- a/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c > +++ b/drivers/platform/x86/hp/hp-bioscfg/bioscfg.c > @@ -7,16 +7,17 @@ > > #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt > > +#include > +#include "../../firmware_attributes_class.h" > #include > -#include > #include > +#include > +#include > #include > #include > #include > + > #include "bioscfg.h" > -#include "../../firmware_attributes_class.h" > -#include > -#include > > MODULE_AUTHOR("Jorge Lopez "); > MODULE_DESCRIPTION("HP BIOS Configuration Driver"); > diff --git a/drivers/platform/x86/lenovo/think-lmi.c > b/drivers/platform/x86/lenovo/think-lmi.c > index e215e86e3db7..9e4b3e973de9 100644 > --- a/drivers/platform/x86/lenovo/think-lmi.c > +++ b/drivers/platform/x86/lenovo/think-lmi.c > @@ -13,14 +13,15 @@ > > #include > #include > +#include > #include > +#include "../firmware_attributes_class.h" > #include > #include > #include > #include > -#include > #include > -#include "../firmware_attributes_class.h" > + > #include "think-lmi.h" > > static bool debug_support; > diff --git a/drivers/platform/x86/lenovo/wmi-other.c > b/drivers/platform/x86/lenovo/wmi-other.c > index fbb32bf404f2..fdebaa0a9992 100644 > --- a/drivers/platform/x86/lenovo/wmi-other.c > +++ b/drivers/platform/x86/lenovo/wmi-other.c > @@ -33,6 +33,7 @@ > #include > #include > #include > +#include "../firmware_attributes_class.h" > #include > #include > #include > @@ -50,7 +51,6 @@ > #include "wmi-capdata.h" > #include "wmi-events.h" > #include "wmi-helpers.h" > -#include "../firmware_attributes_class.h" > > #define LENOVO_OTHER_MODE_GUID "DC2A8805-3A8C-41BA-A6F7-092E0089CD3B" > > diff --git a/drivers/platform/x86/samsung-galaxybook.c > b/drivers/platform/x86/samsung-galaxybook.c > index 6382af0b106c..74103c00b0c8 100644 > --- a/drivers/platform/x86/samsung-galaxybook.c > +++ b/drivers/platform/x86/samsung-galaxybook.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include "firmware_attributes_class.h" > #include > #include > #include > @@ -27,8 +28,8 @@ > #include > #include > #include > + > #include > -#include "firmware_attributes_class.h" > > #define DRIVER_NAME "samsung-galaxybook" > >