Re: [PATCH 04/18] i2c: cadence: remove printout on handled timeouts

Michal Simek
2024-04-11T07:09:37Z

On 4/10/24 13:24, Wolfram Sang wrote:
> I2C and SMBus timeouts are not something the user needs to be informed
> about on controller level. The client driver may know if that really is
> a problem and give more detailed information to the user. The controller
> should just pass this information upwards. Remove the printout.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/i2c/busses/i2c-cadence.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
> index 4bb7d6756947..1b0006e3b95c 100644
> --- a/drivers/i2c/busses/i2c-cadence.c
> +++ b/drivers/i2c/busses/i2c-cadence.c
> @@ -789,8 +789,6 @@ static int cdns_i2c_process_msg(struct cdns_i2c *id, struct i2c_msg *msg,
> time_left = wait_for_completion_timeout(&id->xfer_done, msg_timeout);
> if (time_left == 0) {
> cdns_i2c_master_reset(adap);
> - dev_err(id->adap.dev.parent,
> - "timeout waiting on completion\n");
> return -ETIMEDOUT;
> }
>

Acked-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal