Re: [PATCH 13/18] i2c: rk3x: remove printout on handled timeouts

Dragan Simic
2024-04-12T21:12:52Z

Hello Wolfram,

On 2024-04-10 13:24, Wolfram Sang wrote:
> I2C and SMBus timeouts are not something the user needs to be informed
> about on controller level. The client driver may know if that really is
> a problem and give more detailed information to the user. The
> controller
> should just pass this information upwards. Remove the printout.

Maybe it would be good to turn it into a debug message, instead of
simply removing it? Maybe not all client drivers handle it correctly,
in which case having an easy way for debugging would be beneficial.

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/i2c/busses/i2c-rk3x.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-rk3x.c
> b/drivers/i2c/busses/i2c-rk3x.c
> index 086fdf262e7b..8c7367f289d3 100644
> --- a/drivers/i2c/busses/i2c-rk3x.c
> +++ b/drivers/i2c/busses/i2c-rk3x.c
> @@ -1106,9 +1106,6 @@ static int rk3x_i2c_xfer_common(struct
> i2c_adapter *adap,
> spin_lock_irqsave(&i2c->lock, flags);
>
> if (timeout == 0) {
> - dev_err(i2c->dev, "timeout, ipd: 0x%02x, state: %d\n",
> - i2c_readl(i2c, REG_IPD), i2c->state);
> -
> /* Force a STOP condition without interrupt */
> i2c_writel(i2c, 0, REG_IEN);
> val = i2c_readl(i2c, REG_CON) & REG_CON_TUNING_MASK;