Re: [PATCH 12/18] i2c: qup: remove printout on handled timeouts

Bjorn Andersson
2024-04-11T03:08:14Z

On Wed, Apr 10, 2024 at 01:24:26PM +0200, Wolfram Sang wrote:
> I2C and SMBus timeouts are not something the user needs to be informed
> about on controller level. The client driver may know if that really is
> a problem and give more detailed information to the user. The controller
> should just pass this information upwards. Remove the printout.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
> drivers/i2c/busses/i2c-qup.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qup.c b/drivers/i2c/busses/i2c-qup.c
> index 598102d16677..c9b43a3c4bd3 100644
> --- a/drivers/i2c/busses/i2c-qup.c
> +++ b/drivers/i2c/busses/i2c-qup.c
> @@ -793,10 +793,8 @@ static int qup_i2c_bam_schedule_desc(struct qup_i2c_dev *qup)
> dma_async_issue_pending(qup->brx.dma);
> }
>
> - if (!wait_for_completion_timeout(&qup->xfer, qup->xfer_timeout)) {
> - dev_err(qup->dev, "normal trans timed out\n");
> + if (!wait_for_completion_timeout(&qup->xfer, qup->xfer_timeout))
> ret = -ETIMEDOUT;
> - }
>
> if (ret || qup->bus_err || qup->qup_err) {
> reinit_completion(&qup->xfer);
> --
> 2.43.0
>