Re: [PATCH 11/18] i2c: qcom-geni: remove printout on handled timeouts

Bjorn Andersson
2024-04-11T03:08:01Z

On Wed, Apr 10, 2024 at 01:24:25PM +0200, Wolfram Sang wrote:
> I2C and SMBus timeouts are not something the user needs to be informed
> about on controller level. The client driver may know if that really is
> a problem and give more detailed information to the user. The controller
> should just pass this information upwards. Remove the printout.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

Regards,
Bjorn

> ---
> drivers/i2c/busses/i2c-qcom-geni.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
> index 11dcfcf13d8b..6054c62cd2ff 100644
> --- a/drivers/i2c/busses/i2c-qcom-geni.c
> +++ b/drivers/i2c/busses/i2c-qcom-geni.c
> @@ -642,11 +642,8 @@ static int geni_i2c_gpi_xfer(struct geni_i2c_dev *gi2c, struct i2c_msg msgs[], i
> dma_async_issue_pending(gi2c->tx_c);
>
> timeout = wait_for_completion_timeout(&gi2c->done, XFER_TIMEOUT);
> - if (!timeout) {
> - dev_err(gi2c->se.dev, "I2C timeout gpi flags:%d addr:0x%x\n",
> - gi2c->cur->flags, gi2c->cur->addr);
> + if (!timeout)
> gi2c->err = -ETIMEDOUT;
> - }
>
> if (gi2c->err) {
> ret = gi2c->err;
> --
> 2.43.0
>