From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Ravulapati Vishnu vardhan rao <Vishnuvardhanrao.Ravulapati@amd.com>
Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>,
Maruthi Srinivas Bayyavarapu <Maruthi.Bayyavarapu@amd.com>,
open list <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Akshu.Agrawal@amd.com, Sanju R Mehta <sanju.mehta@amd.com>,
Mark Brown <broonie@kernel.org>,
djkurtz@google.com, Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
Alexander.Deucher@amd.com,
Colin Ian King <colin.king@canonical.com>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [alsa-devel] [PATCH v5 1/6] ASoC: amd:Create multiple I2S platform device Endpoint
Date: Wed, 13 Nov 2019 10:11:48 -0600 [thread overview]
Message-ID: <2febc57c-5cca-b8bd-afdf-a4d77b48c3b0@linux.intel.com> (raw)
In-Reply-To: <1573629249-13272-2-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
> static void snd_acp3x_remove(struct pci_dev *pci)
> {
> + int i;
> struct acp3x_dev_data *adata = pci_get_drvdata(pci);
nit-pick: a lot of kernel folks like xmas-tree style, with counters and
return status declared last.
>
> - platform_device_unregister(adata->pdev);
> + if (adata->acp3x_audio_mode == ACP3x_I2S_MODE) {
> + for (i = 0 ; i < ACP3x_DEVS ; i++)
> + platform_device_unregister(adata->pdev[i]);
> + }
> iounmap(adata->acp3x_base);
>
> pci_disable_msi(pci);
next prev parent reply other threads:[~2019-11-13 17:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1573629249-13272-1-git-send-email-Vishnuvardhanrao.Ravulapati@amd.com>
2019-11-13 7:14 ` [PATCH v5 1/6] ASoC: amd:Create multiple I2S platform device Endpoint Ravulapati Vishnu vardhan rao
2019-11-13 16:11 ` Pierre-Louis Bossart [this message]
2019-11-13 7:14 ` [RESEND PATCH v5 2/6] ASoC: amd: Refactoring of DAI from DMA driver Ravulapati Vishnu vardhan rao
2019-11-13 16:22 ` [alsa-devel] " Pierre-Louis Bossart
2019-11-13 16:36 ` kbuild test robot
2019-11-13 7:14 ` [RESEND PATCH v5 3/6] ASoC: amd: Enabling I2S instance in DMA and DAI Ravulapati Vishnu vardhan rao
2019-11-13 16:29 ` [alsa-devel] " Pierre-Louis Bossart
2019-11-13 7:14 ` [RESEND PATCH v5 4/6] ASoC: amd: add ACP3x TDM mode support Ravulapati Vishnu vardhan rao
2019-11-13 7:14 ` [RESEND PATCH v5 5/6] ASoC: amd: handle ACP3x i2s-sp interrupt Ravulapati Vishnu vardhan rao
2019-11-13 16:31 ` [alsa-devel] " Pierre-Louis Bossart
2019-11-13 7:14 ` [RESEND PATCH v5 6/6] ASoC: amd: Added ACP3x system resume and runtime pm Ravulapati Vishnu vardhan rao
2019-11-13 16:39 ` [alsa-devel] " Pierre-Louis Bossart
2019-11-13 17:13 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2febc57c-5cca-b8bd-afdf-a4d77b48c3b0@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Akshu.Agrawal@amd.com \
--cc=Alexander.Deucher@amd.com \
--cc=Maruthi.Bayyavarapu@amd.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=Vishnuvardhanrao.Ravulapati@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=djkurtz@google.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sanju.mehta@amd.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox