From: Markus Elfring <Markus.Elfring@web.de>
To: David Huang <d-huang@ti.com>, Devarsh Thakkar <devarsht@ti.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Benjamin Gaignard <benjamin.gaignard@collabora.com>,
Conor Dooley <conor+dt@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Sebastian Fricke <sebastian.fricke@collabora.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Andrew Davis <afd@ti.com>,
Andrzej Pietrasiewicz <andrzej.p@collabora.com>,
Aradhya Bhatia <a-bhatia1@ti.com>,
Brandon Brnich <b-brnich@ti.com>,
Darren Etheridge <detheridge@ti.com>,
Jai Luthra <j-luthra@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Nicolas Dufresne <nicolas@ndufresne.ca>,
Nishanth Menon <nm@ti.com>, Praneeth Bajjuri <praneeth@ti.com>,
Prasanth Mantena <p-mantena@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Vijay Pothukuchi <vijayp@ti.com>
Subject: Re: [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver
Date: Tue, 18 Jun 2024 22:46:24 +0200 [thread overview]
Message-ID: <2fed4937-e9ea-4635-a061-5c5a0533b152@web.de> (raw)
In-Reply-To: <20240618193651.2771478-3-devarsht@ti.com>
…
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> @@ -0,0 +1,1741 @@
…
> +static int e5010_release(struct file *file)
> +{
…
> + mutex_lock(&e5010->mutex);
> + v4l2_ctrl_handler_free(&ctx->ctrl_handler);
…
> + kfree(ctx);
> + mutex_unlock(&e5010->mutex);
> +
> + return 0;
> +}
…
Would you become interested to apply a statement like “guard(mutex)(&e5010->mutex);”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196
Regards,
Markus
next prev parent reply other threads:[~2024-06-18 20:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 19:36 [PATCH v14 0/6] Add V4L2 M2M Driver for E5010 JPEG Encoder Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 1/6] media: dt-bindings: Add Imagination " Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver Devarsh Thakkar
2024-06-18 20:46 ` Markus Elfring [this message]
2024-06-21 12:37 ` Sebastian Fricke
2024-06-21 12:44 ` Devarsh Thakkar
2024-06-21 13:26 ` Sebastian Fricke
2024-06-21 14:08 ` Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 3/6] media: v4l2-jpeg: Export reference quantization and huffman tables Devarsh Thakkar
2024-06-20 6:58 ` Hans Verkuil
2024-06-18 19:36 ` [PATCH v14 4/6] media: Documentation: Document v4l2-jpeg helper functions Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 5/6] media: imagination: Use exported tables from v4l2-jpeg core Devarsh Thakkar
2024-06-18 19:36 ` [PATCH v14 6/6] media: verisilicon : Use exported tables from v4l2-jpeg for hantro codec Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2fed4937-e9ea-4635-a061-5c5a0533b152@web.de \
--to=markus.elfring@web.de \
--cc=a-bhatia1@ti.com \
--cc=afd@ti.com \
--cc=andrzej.p@collabora.com \
--cc=b-brnich@ti.com \
--cc=benjamin.gaignard@collabora.com \
--cc=conor+dt@kernel.org \
--cc=d-huang@ti.com \
--cc=detheridge@ti.com \
--cc=devarsht@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=j-luthra@ti.com \
--cc=krzk+dt@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=praneeth@ti.com \
--cc=robh@kernel.org \
--cc=sebastian.fricke@collabora.com \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox