From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7957C43144 for ; Wed, 27 Jun 2018 15:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6A03E25DA1 for ; Wed, 27 Jun 2018 15:31:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A03E25DA1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965602AbeF0Pbx (ORCPT ); Wed, 27 Jun 2018 11:31:53 -0400 Received: from mga06.intel.com ([134.134.136.31]:40847 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754567AbeF0Pbp (ORCPT ); Wed, 27 Jun 2018 11:31:45 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jun 2018 08:31:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,279,1526367600"; d="scan'208";a="50978429" Received: from tkaikuma-mobl.ger.corp.intel.com ([10.249.254.71]) by fmsmga008.fm.intel.com with ESMTP; 27 Jun 2018 08:31:37 -0700 Message-ID: <2fef21b0fb411015cfb748c3fecaf7575652f500.camel@linux.intel.com> Subject: Re: [intel-sgx-kernel-dev] [PATCH v11 13/13] intel_sgx: in-kernel launch enclave From: Jarkko Sakkinen To: Nathaniel McCallum Cc: luto@kernel.org, sean.j.christopherson@intel.com, jethro@fortanix.com, Neil Horman , x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, intel-sgx-kernel-dev@lists.01.org, hpa@zytor.com, dvhart@infradead.org, tglx@linutronix.de, andy@infradead.org, Peter Jones Date: Wed, 27 Jun 2018 18:31:35 +0300 In-Reply-To: References: <20180608171216.26521-14-jarkko.sakkinen@linux.intel.com> <20180611115255.GC22164@hmswarspite.think-freely.org> <20180612174535.GE19168@hmswarspite.think-freely.org> <20180620210158.GA24328@linux.intel.com> <73b7e4e3712074b73f4ac8211699d24dfdced6bf.camel@linux.intel.com> <689641dc26a91f7b4b6bfdb763fec90bf7c3e984.camel@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-06-26 at 11:01 -0400, Nathaniel McCallum wrote: > On Tue, Jun 26, 2018 at 4:44 AM Jarkko Sakkinen > wrote: > > > > On Mon, 2018-06-25 at 08:45 -0700, Andy Lutomirski wrote: > > > I'm personally rather strongly in favor of the vastly simpler model in > > > which we first merge SGX without LE support at all. Instead we use > > > the approach where we just twiddle the MSRs to launch normal enclaves > > > without an init token at all, which is probably considerably faster > > > and will remove several thousand lines of code. If and when a bona > > > fide use case for LE support shows up, we can work out the details and > > > merge it. > > > > Andy, I was going to propose exactly the same :-) > > > > We can upstream SGX that supports only unlocked MSRs and that does > > not preventing to upstream support for locked MSRs later. Even if > > we had a consensus for locked MSRs, making two milestones for the > > mainline would make perfect sense. > > > > I came into this conclusion last night because all the other review > > comments not concerning the launch control are easily sorted out. > > +1. Let's do this and get it merged without launch enclave support > lockdown now. We can revisit this once we have hands on experience > with the technology. I'm proceeding with this ATM. I'm going to send v12 next week. I'll do my best to address all of the review comments but expect to miss some of them. /Jarkko