From: Roger Quadros <rogerq@kernel.org>
To: "Rob Herring (Arm)" <robh@kernel.org>,
Aaro Koskinen <aaro.koskinen@iki.fi>,
Andreas Kemnade <andreas@kemnade.info>,
Kevin Hilman <khilman@baylibre.com>,
Tony Lindgren <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: ti-sysc: Use of_property_present()
Date: Sat, 3 Aug 2024 17:56:28 +0300 [thread overview]
Message-ID: <2ff177ed-a5e8-46ad-9902-14f377033da2@kernel.org> (raw)
In-Reply-To: <20240731191312.1710417-1-robh@kernel.org>
On 31/07/2024 22:12, Rob Herring (Arm) wrote:
> Use of_property_present() to test for property presence rather than
> of_get_property(). This is part of a larger effort to remove callers
> of of_get_property() and similar functions. of_get_property() leaks
> the DT property data pointer which is a problem for dynamically
> allocated nodes which may be freed.
>
> The code was also incorrectly assigning the return value to a 'struct
> property' pointer. It didn't matter as "prop" was never dereferenced.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed by: Roger Quadros <rogerq@kernel.org>
next prev parent reply other threads:[~2024-08-03 14:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-31 19:12 [PATCH] bus: ti-sysc: Use of_property_present() Rob Herring (Arm)
2024-08-03 14:56 ` Roger Quadros [this message]
2024-08-05 17:36 ` Kevin Hilman
2024-08-06 5:40 ` Roger Quadros
2024-08-05 17:37 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2ff177ed-a5e8-46ad-9902-14f377033da2@kernel.org \
--to=rogerq@kernel.org \
--cc=aaro.koskinen@iki.fi \
--cc=andreas@kemnade.info \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox