* [PATCH v4 1/2] arm64: dts: qcom: sa8775p: add DisplayPort device nodes
2024-11-20 10:59 [PATCH v4 0/2] Enable Display Port for Qualcomm SA8775P-ride platform Soutrik Mukhopadhyay
@ 2024-11-20 10:59 ` Soutrik Mukhopadhyay
2024-11-20 11:23 ` Dmitry Baryshkov
2024-11-20 10:59 ` [PATCH v4 2/2] arm64: dts: qcom: sa8775p-ride: Enable Display Port Soutrik Mukhopadhyay
2024-11-20 11:06 ` [PATCH v4 0/2] Enable Display Port for Qualcomm SA8775P-ride platform Dmitry Baryshkov
2 siblings, 1 reply; 8+ messages in thread
From: Soutrik Mukhopadhyay @ 2024-11-20 10:59 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: Soutrik Mukhopadhyay, linux-arm-msm, devicetree, linux-kernel,
quic_riteshk, quic_vproddut, quic_abhinavk
Add device tree nodes for the DPTX0 and DPTX1 controllers
with their corresponding PHYs found on Qualcomm SA8775P SoC.
Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com>
---
arch/arm64/boot/dts/qcom/sa8775p.dtsi | 218 +++++++++++++++++++++++++-
1 file changed, 217 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
index f7a9d1684a79..7fd0d89bf7a9 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
@@ -3343,6 +3343,25 @@
interrupt-parent = <&mdss0>;
interrupts = <0>;
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ dpu_intf0_out: endpoint {
+ remote-endpoint = <&mdss0_dp0_in>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ dpu_intf4_out: endpoint {
+ remote-endpoint = <&mdss0_dp1_in>;
+ };
+ };
+ };
+
mdss0_mdp_opp_table: opp-table {
compatible = "operating-points-v2";
@@ -3367,6 +3386,202 @@
};
};
};
+
+ mdss0_dp0_phy: phy@aec2a00 {
+ compatible = "qcom,sa8775p-edp-phy";
+
+ reg = <0x0 0xaec2a00 0x0 0x200>,
+ <0x0 0xaec2200 0x0 0xd0>,
+ <0x0 0xaec2600 0x0 0xd0>,
+ <0x0 0xaec2000 0x0 0x1c8>;
+
+ clocks =<&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
+ clock-names = "aux",
+ "cfg_ahb";
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ status = "disabled";
+ };
+
+ mdss0_dp1_phy: phy@aec5a00 {
+ compatible = "qcom,sa8775p-edp-phy";
+
+ reg = <0x0 0xaec5a00 0x0 0x200>,
+ <0x0 0xaec5200 0x0 0xd0>,
+ <0x0 0xaec5600 0x0 0xd0>,
+ <0x0 0xaec5000 0x0 0x1c8>;
+
+ clocks =<&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>;
+ clock-names = "aux",
+ "cfg_ahb";
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ status = "disabled";
+ };
+
+ mdss0_dp0: displayport-controller@af54000 {
+ compatible = "qcom,sa8775p-dp";
+
+ reg = <0x0 0xaf54000 0x0 0x104>,
+ <0x0 0xaf54200 0x0 0x0c0>,
+ <0x0 0xaf55000 0x0 0x770>,
+ <0x0 0xaf56000 0x0 0x09c>,
+ <0x0 0xaf57000 0x0 0x09c>;
+
+ interrupt-parent = <&mdss0>;
+ interrupts = <12>;
+
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK>;
+ clock-names = "core_iface",
+ "core_aux",
+ "ctrl_link",
+ "ctrl_link_iface",
+ "stream_pixel";
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK_SRC>;
+ assigned-clock-parents = <&mdss0_dp0_phy 0>, <&mdss0_dp0_phy 1>;
+ phys = <&mdss0_dp0_phy>;
+ phy-names = "dp";
+
+ operating-points-v2 = <&dp_opp_table>;
+ power-domains = <&rpmhpd SA8775P_MMCX>;
+
+ #sound-dai-cells = <0>;
+
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ mdss0_dp0_in: endpoint {
+ remote-endpoint = <&dpu_intf0_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ mdss0_dp0_out: endpoint { };
+ };
+ };
+
+ dp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-270000000 {
+ opp-hz = /bits/ 64 <270000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+
+ opp-540000000 {
+ opp-hz = /bits/ 64 <540000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-810000000 {
+ opp-hz = /bits/ 64 <810000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+
+ mdss0_dp1: displayport-controller@af5c000 {
+ compatible = "qcom,sa8775p-dp";
+
+ reg = <0x0 0xaf5c000 0x0 0x104>,
+ <0x0 0xaf5c200 0x0 0x0c0>,
+ <0x0 0xaf5d000 0x0 0x770>,
+ <0x0 0xaf5e000 0x0 0x09c>,
+ <0x0 0xaf5f000 0x0 0x09c>;
+
+ interrupt-parent = <&mdss0>;
+ interrupts = <13>;
+
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_INTF_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK>;
+ clock-names = "core_iface",
+ "core_aux",
+ "ctrl_link",
+ "ctrl_link_iface",
+ "stream_pixel";
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK_SRC>;
+ assigned-clock-parents = <&mdss0_dp1_phy 0>, <&mdss0_dp1_phy 1>;
+ phys = <&mdss0_dp1_phy>;
+ phy-names = "dp";
+
+ operating-points-v2 = <&dp1_opp_table>;
+ power-domains = <&rpmhpd SA8775P_MMCX>;
+
+ #sound-dai-cells = <0>;
+
+ status = "disabled";
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+
+ mdss0_dp1_in: endpoint {
+ remote-endpoint = <&dpu_intf4_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+
+ mdss0_dp1_out: endpoint { };
+ };
+ };
+
+ dp1_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-160000000 {
+ opp-hz = /bits/ 64 <160000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-270000000 {
+ opp-hz = /bits/ 64 <270000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+
+ opp-540000000 {
+ opp-hz = /bits/ 64 <540000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-810000000 {
+ opp-hz = /bits/ 64 <810000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
};
dispcc0: clock-controller@af00000 {
@@ -3376,7 +3591,8 @@
<&rpmhcc RPMH_CXO_CLK>,
<&rpmhcc RPMH_CXO_CLK_A>,
<&sleep_clk>,
- <0>, <0>, <0>, <0>,
+ <&mdss0_dp0_phy 0>, <&mdss0_dp0_phy 1>,
+ <&mdss0_dp1_phy 0>, <&mdss0_dp1_phy 1>,
<0>, <0>, <0>, <0>;
power-domains = <&rpmhpd SA8775P_MMCX>;
#clock-cells = <1>;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [PATCH v4 2/2] arm64: dts: qcom: sa8775p-ride: Enable Display Port
2024-11-20 10:59 [PATCH v4 0/2] Enable Display Port for Qualcomm SA8775P-ride platform Soutrik Mukhopadhyay
2024-11-20 10:59 ` [PATCH v4 1/2] arm64: dts: qcom: sa8775p: add DisplayPort device nodes Soutrik Mukhopadhyay
@ 2024-11-20 10:59 ` Soutrik Mukhopadhyay
2024-11-20 11:12 ` Dmitry Baryshkov
2024-11-20 11:06 ` [PATCH v4 0/2] Enable Display Port for Qualcomm SA8775P-ride platform Dmitry Baryshkov
2 siblings, 1 reply; 8+ messages in thread
From: Soutrik Mukhopadhyay @ 2024-11-20 10:59 UTC (permalink / raw)
To: andersson, konradybcio, robh, krzk+dt, conor+dt
Cc: Soutrik Mukhopadhyay, linux-arm-msm, devicetree, linux-kernel,
quic_riteshk, quic_vproddut, quic_abhinavk
Enable DPTX0 and DPTX1 along with their corresponding PHYs for
sa8775p-ride platform.
Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com>
---
arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++++++++++++++++
1 file changed, 80 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
index adb71aeff339..4847e4942386 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
@@ -27,6 +27,30 @@
chosen {
stdout-path = "serial0:115200n8";
};
+
+ dp0-connector {
+ compatible = "dp-connector";
+ label = "DP0";
+ type = "full-size";
+
+ port {
+ dp0_connector_in: endpoint {
+ remote-endpoint = <&mdss0_dp0_out>;
+ };
+ };
+ };
+
+ dp1-connector {
+ compatible = "dp-connector";
+ label = "DP1";
+ type = "full-size";
+
+ port {
+ dp1_connector_in: endpoint {
+ remote-endpoint = <&mdss0_dp1_out>;
+ };
+ };
+ };
};
&apps_rsc {
@@ -421,6 +445,50 @@
status = "okay";
};
+&mdss0 {
+ status = "okay";
+};
+
+&mdss0_dp0 {
+ status = "okay";
+
+ pinctrl-0 = <&dp0_hot_plug_det>;
+ pinctrl-names = "default";
+};
+
+&mdss0_dp0_out {
+ data-lanes = <0 1 2 3>;
+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+ remote-endpoint = <&dp0_connector_in>;
+};
+
+&mdss0_dp0_phy {
+ status = "okay";
+
+ vdda-phy-supply = <&vreg_l1c>;
+ vdda-pll-supply = <&vreg_l4a>;
+};
+
+&mdss0_dp1 {
+ status = "okay";
+
+ pinctrl-0 = <&dp1_hot_plug_det>;
+ pinctrl-names = "default";
+};
+
+&mdss0_dp1_out {
+ data-lanes = <0 1 2 3>;
+ link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>;
+ remote-endpoint = <&dp1_connector_in>;
+};
+
+&mdss0_dp1_phy {
+ status = "okay";
+
+ vdda-phy-supply = <&vreg_l1c>;
+ vdda-pll-supply = <&vreg_l4a>;
+};
+
&pmm8654au_0_gpios {
gpio-line-names = "DS_EN",
"POFF_COMPLETE",
@@ -527,6 +595,18 @@
};
&tlmm {
+ dp0_hot_plug_det: dp0-hot-plug-det-state {
+ pins = "gpio101";
+ function = "edp0_hot";
+ bias-disable;
+ };
+
+ dp1_hot_plug_det: dp1-hot-plug-det-state {
+ pins = "gpio102";
+ function = "edp1_hot";
+ bias-disable;
+ };
+
ethernet0_default: ethernet0-default-state {
ethernet0_mdc: ethernet0-mdc-pins {
pins = "gpio8";
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH v4 0/2] Enable Display Port for Qualcomm SA8775P-ride platform
2024-11-20 10:59 [PATCH v4 0/2] Enable Display Port for Qualcomm SA8775P-ride platform Soutrik Mukhopadhyay
2024-11-20 10:59 ` [PATCH v4 1/2] arm64: dts: qcom: sa8775p: add DisplayPort device nodes Soutrik Mukhopadhyay
2024-11-20 10:59 ` [PATCH v4 2/2] arm64: dts: qcom: sa8775p-ride: Enable Display Port Soutrik Mukhopadhyay
@ 2024-11-20 11:06 ` Dmitry Baryshkov
2 siblings, 0 replies; 8+ messages in thread
From: Dmitry Baryshkov @ 2024-11-20 11:06 UTC (permalink / raw)
To: Soutrik Mukhopadhyay
Cc: andersson, konradybcio, robh, krzk+dt, conor+dt, linux-arm-msm,
devicetree, linux-kernel, quic_riteshk, quic_vproddut,
quic_abhinavk
On Wed, Nov 20, 2024 at 04:29:52PM +0530, Soutrik Mukhopadhyay wrote:
> This series adds the DPTX0 and DPTX1 nodes, as a part of mdss0
> on Qualcomm SA8775P SoC. It also enables Display Port on Qualcomm
> SA8775P-ride platform.
>
> ---
> This patch depends on following series:
> https://lore.kernel.org/all/20240816-sa8775p-mm-v3-v1-0-77d53c3c0cef@quicinc.com/
> https://lore.kernel.org/all/20241019-patchv3_1-v5-0-d2fb72c9a845@quicinc.com/
> https://lore.kernel.org/all/20241018070706.28980-1-quic_mukhopad@quicinc.com/
>
> v2: Fixed review comments from Dmitry, Konrad and Bjorn
> - Added a new patchset to separate out the soc and board parts.[Konrad]
> - Patchset 1 now comprises of the soc parts and patchset 2 includes board specific changes.[Bjorn]
> - Patchset 2 enables all the DP ports validated on the sa8775p-ride platform.[Bjorn]
> - Fixed indentation errors in the dtsi file containing the soc information.[Dmitry][Konrad]
> - Updated clocks to be used by respective PHYs.[Dmitry]
> - Added mdss0_dp1 device node.[Dmitry]
> - Updated the names of PHYs using label prefix "mdssM_dpN" for clarity.[Bjorn]
> - Avoided use of referring any label in the board(dts) file in the dtsi(platform) file.[Bjorn]
>
> v3: Fixed review comments from Dmitry and other minor changes to prevent warnings and maintain alignment
> - Added specific DP connector node for each DP port validated in patchset 2.[Dmitry]
> - Updated the reg value to 1 for port 1 under mdss_mdp in patchset 1.
> - Fixed the register address space for mdss0_dp1 and mdss0_dp1_phy in alignment to the
> register address space for mdss0_dp0 and mdss0_dp0_phy, in patchset 1.
>
> v4: Fixed review comments from Dmitry
> - Added p1 region to the register set of both mdss_dp0 and mdss_dp1
> alongside validation of devicetree against DT schema.[Dmitry]
NIT: Please describe changes in the logical order: newer aka interesting
items in the top, historical changes at the bottom. The "b4" tool would
have handled it for you.
>
> ---
>
> Soutrik Mukhopadhyay (2):
> arm64: dts: qcom: sa8775p: add DisplayPort device nodes
> arm64: dts: qcom: sa8775p-ride: Enable Display Port
>
> arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++
> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 218 ++++++++++++++++++++-
> 2 files changed, 297 insertions(+), 1 deletion(-)
>
> --
> 2.17.1
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 8+ messages in thread