From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 795A61F192E for ; Tue, 7 Apr 2026 10:55:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559349; cv=none; b=tiJKii5XaFuPFHp0G6wHJIhose6g9RVVf0LJYKraNZJmasvBmYlEdzxSsoHdlx855gKcgSwlxdc4AbNipaAWVnasFwEOCoYD9NupSpDoaFpyNPaNH8CFQqMNMZgTqB63UjoGYyykY3iyo618gRNivomoF6X/CN7m50t4aJRmVJw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775559349; c=relaxed/simple; bh=DxuZSc3v1tSfQiDDs//E7vQOyQAhy+CLZFc51VXzKJk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=g0Wz/OSfto99vKJr+UYvTgRZRn57MskVebBLojkShYGkXGvvbDOdTvV+zYAWTJPmBrw2lGrqqgQb7k38dILIou2Z9S54LP40gbfWEZdR+iVv8NCvyla17DITHvqWGUcoiCvUiW+27ZQipDnYyR3cW3w09UTXUUXUriL2HF4iNTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XechboWm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XechboWm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7AC4C116C6; Tue, 7 Apr 2026 10:55:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775559349; bh=DxuZSc3v1tSfQiDDs//E7vQOyQAhy+CLZFc51VXzKJk=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=XechboWmrDEra1UKD/89mEc9VgqVKZx3trOiVrC2/tPXI8bAdnlaWYBhgZLst0KcG pv/reEJAnUvUsgWWsJ5FcBt0hpoLloMwlvhP366kBM3swg2PNDA1w5sJPF0hV0grIA 1LmTg9zM+dEjCq/zebv3ikJrelbboAOUtySOSIE9p8LrHLrQ/So4OkLKg6DzcCBWtN FcMrcMKD64JBsZztcunV4e1hnvpWSrYrlccRqXGQKx/lpvat9sFX+KHRBqcotVpE57 dt2LuTyKYFxNonlTsFkFkTZmeMEOZE6p91pZ6k+IweMUdSTBBpY/FjTzHtMryDjPES fK5xLlehLs90A== From: Pratyush Yadav To: Mike Rapoport Cc: Michal Clapinski , Evangelos Petrongonas , Pasha Tatashin , Pratyush Yadav , Alexander Graf , Samiullah Khawaja , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton Subject: Re: [PATCH v7 1/3] kho: make kho_scratch_overlap usable outside debugging In-Reply-To: (Mike Rapoport's message of "Wed, 18 Mar 2026 11:16:51 +0200") References: <20260317141534.815634-1-mclapinski@google.com> <20260317141534.815634-2-mclapinski@google.com> Date: Tue, 07 Apr 2026 10:55:45 +0000 Message-ID: <2vxz1pgravke.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Wed, Mar 18 2026, Mike Rapoport wrote: > Hi Michal, > > On Tue, Mar 17, 2026 at 03:15:32PM +0100, Michal Clapinski wrote: >> Also return false if kho_scratch is NULL. >> [...] >> diff --git a/kernel/liveupdate/Makefile b/kernel/liveupdate/Makefile >> index d2f779cbe279..dc352839ccf0 100644 >> --- a/kernel/liveupdate/Makefile >> +++ b/kernel/liveupdate/Makefile >> @@ -7,7 +7,6 @@ luo-y := \ >> luo_session.o >> >> obj-$(CONFIG_KEXEC_HANDOVER) += kexec_handover.o >> -obj-$(CONFIG_KEXEC_HANDOVER_DEBUG) += kexec_handover_debug.o >> obj-$(CONFIG_KEXEC_HANDOVER_DEBUGFS) += kexec_handover_debugfs.o >> >> obj-$(CONFIG_LIVEUPDATE) += luo.o >> diff --git a/kernel/liveupdate/kexec_handover.c b/kernel/liveupdate/kexec_handover.c >> index 532f455c5d4f..c9b982372d6e 100644 >> --- a/kernel/liveupdate/kexec_handover.c >> +++ b/kernel/liveupdate/kexec_handover.c >> @@ -820,7 +820,8 @@ int kho_preserve_folio(struct folio *folio) >> const unsigned long pfn = folio_pfn(folio); >> const unsigned int order = folio_order(folio); >> >> - if (WARN_ON(kho_scratch_overlap(pfn << PAGE_SHIFT, PAGE_SIZE << order))) >> + if (WARN_ON(kho_scratch_overlap_debug(pfn << PAGE_SHIFT, >> + PAGE_SIZE << order))) > > Can't say I'm fond of kho_scratch_overlap_debug(). How about we make it > > if (IS_ENABLED(CONFIG_KEXEC_HANDOVER_DEBUG) && > WARN_ON(kho_scratch_overlap(...)) +1. And we can get rid of kexec_handover_debug.c, for now at least. We can add it back when we have something else to put in there. > >> return -EINVAL; >> >> return kho_radix_add_page(tree, pfn, order); [...] -- Regards, Pratyush Yadav