From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BADE486E46 for ; Wed, 29 Jul 2026 14:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785334806; cv=none; b=cwQL3Hzi3Pr6x1NC97S9ATmE2/yRAJW6qdi7hQG+tjXtMNrRvT0/OvhahUiucm9v7tM8CeeNOiidrJ8NLdZvl3OaCKucsADIgAl63jlOb/Gb1H6ZqdRguM5A9G2A/MrAbgnUq/P8/c0yWwU9rrgok/Zw4utWpJWAt75qvQnWpEc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785334806; c=relaxed/simple; bh=TaP6axJAkhlEPvrp3kaC/LLaiY1ZsElSPjQ22HUL8NA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WzBFlKP5Sr/DhfgB/G++OD3Y/vp3Pz4Sz0cldIYGAQ3cB6V3mTuYMCWRTq8vXCChEcQqp3bFXek4M6GG9TEpYHfP5MFS/dMOZLYz7Xzg5iYjyJFLxfL7+7uXI32On0u7XyrcsomX0oLmuFHuuPx6KM9vSGYAbSSYSbKiG1k+tZA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Qbnf2thC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Qbnf2thC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7484E1F000E9; Wed, 29 Jul 2026 14:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785334804; bh=ToiJoF4NcsxRlbsxS2U0VQ57R0XjAeQgD4aiE3GQTgU=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=Qbnf2thCmDftHpU293Cjw8f+lvQqn3HXrlqAxa+6XB7oBenqHteYwSX88ZeqJZJ3x xcOYql4hyNOsX7Go1UZO9BQIFfeyGo9BOyt0M5W8+BiTH2aSK6V5QA41+g1q8SWpLS IOnJJzNYleeMxT5+if5EdiAX38V+rB7wFMtDMZlUcP/aLjrIFqorv/heZaOrbndoif gxtdY6a/n4/fRt2tcEsuf2XuLXQQMyxJnMQgv2O12AUkbzP2mZlhhpJlfQd/8y3xXV t2KDAoIQMcPKqkZi28muGaVdiRqw/V+EF7w406MnK/VV+0a05+iLaTGDX6LWPetjG0 iOPMTmp00QMgQ== From: Pratyush Yadav To: Mike Rapoport Cc: Pratyush Yadav , Pasha Tatashin , Alexander Graf , Muchun Song , Oscar Salvador , David Hildenbrand , Andrew Morton , Jason Miu , Jork Loeser , kexec@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 19/21] memblock: make HugeTLB bootmem allocation work with KHO In-Reply-To: (Mike Rapoport's message of "Tue, 28 Jul 2026 20:45:36 +0300") References: <20260725172133.4018491-1-pratyush@kernel.org> <20260725172133.4018491-20-pratyush@kernel.org> Date: Wed, 29 Jul 2026 16:20:01 +0200 Message-ID: <2vxz33x198tq.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain On Tue, Jul 28 2026, Mike Rapoport wrote: > On Sat, Jul 25, 2026 at 07:21:19PM +0200, Pratyush Yadav wrote: >> >> diff --git a/mm/memblock.c b/mm/memblock.c >> index 8b2e551435ae..ff470fd0fd10 100644 >> --- a/mm/memblock.c >> +++ b/mm/memblock.c >> @@ -19,11 +19,9 @@ >> #include >> #include >> >> -#ifdef CONFIG_KEXEC_HANDOVER >> #include >> #include >> #include >> -#endif /* CONFIG_KEXEC_HANDOVER */ > > This breaks memblock tests, can you please add stubs for these in > tools/testing/memblock? I swear I tried building memblock tests but somehow still missed this :-(. I think it is because the very last thing I tested was a boot with KHO disabled, and that's when I discovered this. Anyway, will fix in next version. -- Regards, Pratyush Yadav